nova-network allow creating network with invalid vlan number

Bug #1334563 reported by Dong Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Dong Liu

Bug Description

My openstack use nova network service, I create network with "vlan" parameter.
I can create network with vlan 4097. As we known, this is a invalid vlan number.

This is my request body:
{
  "network": {
    "cidr": "192.168.50.0/24",
    "vlan": "4097",
    "label": "testnetwork01"
  }
}

This is response:
{
  "network": {
    "bridge": "br4097",
    "vpn_public_port": 1006,
    "dhcp_start": "192.168.50.3",
    "bridge_interface": "brcps",
    "updated_at": null,
    "id": "c5bd9589-5310-4cd2-8d2a-413db609e88b",
    "cidr_v6": null,
    "deleted_at": null,
    "gateway": "192.168.50.1",
    "rxtx_base": null,
    "label": "testnetwork01",
    "priority": null,
    "project_id": null,
    "vpn_private_address": "192.168.50.2",
    "deleted": 0,
    "vlan": "4097",
    "broadcast": "192.168.50.255",
    "netmask": "255.255.255.0",
    "injected": false,
    "cidr": "192.168.50.0/24",
    "vpn_public_address": null,
    "multi_host": false,
    "dns2": null,
    "created_at": "2014-06-26T16:23:01.309176",
    "host": null,
    "gateway_v6": null,
    "netmask_v6": null,
    "dns1": "8.8.4.4"
  }
}

I think we should check this parameter.

Dong Liu (liudong78)
Changed in neutron:
assignee: nobody → Dong Liu (liudong78)
affects: neutron → nova
Changed in nova:
assignee: Dong Liu (liudong78) → nobody
assignee: nobody → Dong Liu (liudong78)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102777

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/102777
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b7d175641b4413a9d6664e7826e9b5497e125b0
Submitter: Jenkins
Branch: master

commit 1b7d175641b4413a9d6664e7826e9b5497e125b0
Author: liudong <email address hidden>
Date: Thu Jun 26 17:07:39 2014 +0800

    Check vlan parameter is valid

    Now, we can create network with invalid vlan with nova-network.
    Check if vlan parameter is greater than 4094 or less than 1.

    Change-Id: I27a74fb76ba575f43fee669c0c495e0ef96d4b18
    Closes-Bug: #1334563

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.