state/apiserver: more data races

Bug #1334500 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Critical
Dave Cheney

Bug Description

2014/06/26 13:55:12 http: TLS handshake error from 127.0.0.1:39566: tls: first record does not look like a TLS handshake
2014/06/26 13:55:47 http: TLS handshake error from 127.0.0.1:41210: tls: first record does not look like a TLS handshake
==================
WARNING: DATA RACE
Write by goroutine 251:
  github.com/juju/juju/state/apiserver.(*Server).validateEnvironUUID()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:289 +0x164
  github.com/juju/juju/state/apiserver.(*Server).serveConn()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:309 +0x2b2
  github.com/juju/juju/state/apiserver.func·004()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:260 +0x379
  code.google.com/p/go.net/websocket.Server.serveWebSocket()
      /home/dfc/src/code.google.com/p/go.net/websocket/server.go:90 +0x2d2
  code.google.com/p/go.net/websocket.Server.ServeHTTP()
      /home/dfc/src/code.google.com/p/go.net/websocket/server.go:70 +0x6b
  github.com/juju/juju/state/apiserver.(*Server).apiHandler()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:265 +0x23e
  github.com/juju/juju/state/apiserver.*Server.(github.com/juju/juju/state/apiserver.apiHandler)·fm()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:220 +0x51
  net/http.HandlerFunc.ServeHTTP()
      /home/dfc/go/src/pkg/net/http/server.go:1235 +0x4d
  github.com/bmizerany/pat.(*PatternServeMux).ServeHTTP()
      /home/dfc/src/github.com/bmizerany/pat/mux.go:109 +0x33a
  net/http.serverHandler.ServeHTTP()
      /home/dfc/go/src/pkg/net/http/server.go:1673 +0x1fc
  net/http.(*conn).serve()
      /home/dfc/go/src/pkg/net/http/server.go:1174 +0xf9e

Previous write by goroutine 250:
  github.com/juju/juju/state/apiserver.(*Server).validateEnvironUUID()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:289 +0x164
  github.com/juju/juju/state/apiserver.(*Server).serveConn()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:309 +0x2b2
  github.com/juju/juju/state/apiserver.func·004()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:260 +0x379
  code.google.com/p/go.net/websocket.Server.serveWebSocket()
      /home/dfc/src/code.google.com/p/go.net/websocket/server.go:90 +0x2d2
  code.google.com/p/go.net/websocket.Server.ServeHTTP()
      /home/dfc/src/code.google.com/p/go.net/websocket/server.go:70 +0x6b
  github.com/juju/juju/state/apiserver.(*Server).apiHandler()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:265 +0x23e
  github.com/juju/juju/state/apiserver.*Server.(github.com/juju/juju/state/apiserver.apiHandler)·fm()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:220 +0x51
  net/http.HandlerFunc.ServeHTTP()
      /home/dfc/go/src/pkg/net/http/server.go:1235 +0x4d
  github.com/bmizerany/pat.(*PatternServeMux).ServeHTTP()
      /home/dfc/src/github.com/bmizerany/pat/mux.go:109 +0x33a
  net/http.serverHandler.ServeHTTP()
      /home/dfc/go/src/pkg/net/http/server.go:1673 +0x1fc
  net/http.(*conn).serve()
      /home/dfc/go/src/pkg/net/http/server.go:1174 +0xf9e

Goroutine 251 (running) created at:
  net/http.(*Server).Serve()
      /home/dfc/go/src/pkg/net/http/server.go:1721 +0x35d
  net/http.Serve()
      /home/dfc/go/src/pkg/net/http/server.go:1576 +0xb8
  github.com/juju/juju/state/apiserver.(*Server).run()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:240 +0xb96

Goroutine 250 (running) created at:
  net/http.(*Server).Serve()
      /home/dfc/go/src/pkg/net/http/server.go:1721 +0x35d
  net/http.Serve()
      /home/dfc/go/src/pkg/net/http/server.go:1576 +0xb8
  github.com/juju/juju/state/apiserver.(*Server).run()
      /home/dfc/src/github.com/juju/juju/state/apiserver/apiserver.go:240 +0xb96
==================
2014/06/26 13:56:21 http: TLS handshake error from 127.0.0.1:51321: tls: first record does not look like a TLS handshake
OK: 106 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/state/apiserver 86.298s

Ian Booth (wallyworld)
Changed in juju-core:
milestone: 1.19.4 → none
milestone: none → next-stable
status: Triaged → In Progress
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: next-stable → 1.21-alpha1
Curtis Hovey (sinzui)
tags: added: api fallout
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.