[Upgrade] can not download snapshot after upgrade

[Tatyanka]

{"build_id": "2014-06-20_00-31-14", "mirantis": "yes", "build_number": "262", "ostf_sha": "2f30e5cab5bec1f1e2fd80e26e4da771a8ffe2d4", "nailgun_sha": "0c5e3b94fdd6bc9a50d5f840bf5151f95a23d908", "production": "docker", "api": "1.0", "fuelmain_sha": "4f547561532baf5f26733bf66db692dc5b61806d", "astute_sha": "694b5a55695e01e1c42185bfac9cc7a641a9bd48", "release": "5.1", "fuellib_sha": "25eb618a33a2ec87bc56f6bad16dc25b1837f0f0"}

Steps:
1. Deploy Simple flat on Centos
2. Download latest tar archive on the master node
3. Run upgrade
4. As soon as it finishes with success generate snapshot
5. Download it

Expected Result:
snapshot was downloaded

Actual result:
403 forbidden error shos, but snapshot is placed in nginx container in /var/www/nailgun/dump

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/102488

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/102488
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=86cd7a3cf72c0dc5d7f6c5ba4ad0ab6459681839
Submitter: Jenkins
Branch: master

commit 86cd7a3cf72c0dc5d7f6c5ba4ad0ab6459681839
Author: Evgeniy L <email address hidden>
Date: Wed Jun 25 13:57:42 2014 +0400

    Fix nginx start.sh script, to set right permissions for dump directory

    Run `chmod -R 755 /var/www/nailgun/*`, to
    set permissions for /var/www/nailgun/dump
    which is symlink to /dump. We have to do it,
    because chmod -R doesn't follow symlinks.

    Change-Id: I43f9b9164d8f0f4d8ddb7d06cc2549145bd135bb
    Closes-bug: #1333631

[Tatyanka (tatyana-leontovich)]

verified {"build_id": "2014-07-01_16-14-45", "ostf_sha": "7171951202a22d8dfe9b3b76c9824001e2485630", "build_number": "259", "api": "1.0", "nailgun_sha": "6758240cc36fe07c6303b4bda662a2ddb65f1113", "production": "docker", "fuelmain_sha": "7ac4830845d4a372f7fbd12d0f1c749236117a25", "astute_sha": "6ed4d5a2d59675a59bb3f5bc94851ff13a4a4468", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "a9f86e45b3ccee4d57da00d60a6c521e718e703b"}

[Andrey Sledzinskiy (asledzinskiy)]

Bug is also reproduced with 5.0.1 upgrade script - fuel-5.0.1-upgrade-17-2014-07-01_12-14-51.tar

build_id": "2014-05-27_05-51-41",
"mirantis": "yes",
"build_number": "26",
"ostf_sha": "a8b7660082a6f152794c610d6abe30d360fd577d",
"nailgun_sha": "bd09f89ef56176f64ad5decd4128933c96cb20f4",
"production": "docker",
"api": "1.0",
"fuelmain_sha": "505741e4f431f85a8d0252fc42754d10c0326c1a",
"astute_sha": "a7eac46348dc77fc2723c6fcc3dbc66cc1a83152",
"release": "5.0",
"fuellib_sha": "2f79c0415159651fc1978d99bd791079d1ae4a06"

[Andrey Sledzinskiy (asledzinskiy)]

Verified on fuel-5.0.1-upgrade-23-2014-07-02_21-27-32.tar

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/104483

[Aleksey Kasatkin (alekseyk-ru)]

Same problem on master upgraded from 5.0 to 5.0.1 w/o deployed environments.
Snapshots are here actually:

[root@fuel ~]# find /var/ -name "fuel-snapshot*"
/var/lib/docker/vfs/dir/5be87687f82fa75de5acb9872d333fa64d25d5d600857917019c6dc4ca020c3c/fuel-snapshot-2014-07-03_10-28-21.tgz
/var/lib/docker/vfs/dir/5be87687f82fa75de5acb9872d333fa64d25d5d600857917019c6dc4ca020c3c/fuel-snapshot-2014-07-03_10-34-08.tgz
/var/lib/docker/vfs/dir/5be87687f82fa75de5acb9872d333fa64d25d5d600857917019c6dc4ca020c3c/fuel-snapshot-2014-07-03_10-35-11.tgz
/var/lib/docker/vfs/dir/5be87687f82fa75de5acb9872d333fa64d25d5d600857917019c6dc4ca020c3c/fuel-snapshot-2014-07-03_10-38-30.tgz

It works after "chmod -R 755 /var/lib/docker/* 2>/dev/null"

[Aleksey Kasatkin (alekseyk-ru)]

Got it. I had to run it from nginx container.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104483
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=75d52cc497346dd3d6aa8babe199c9b9fd52d9e7
Submitter: Jenkins
Branch: stable/5.0

commit 75d52cc497346dd3d6aa8babe199c9b9fd52d9e7
Author: Evgeniy L <email address hidden>
Date: Wed Jun 25 13:57:42 2014 +0400

    Fix nginx start.sh script, to set right permissions for dump directory

    Run `chmod -R 755 /var/www/nailgun/*`, to
    set permissions for /var/www/nailgun/dump
    which is symlink to /dump. We have to do it,
    because chmod -R doesn't follow symlinks.

    Change-Id: I43f9b9164d8f0f4d8ddb7d06cc2549145bd135bb
    Closes-bug: #1333631