Add validation when user tries to upgrade fuel master to version that is already installed

Bug #1333584 reported by Andrey Sledzinskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Evgeniy L

Bug Description

Add validation when user tries to upgrade fuel master to version that is already installed

Tags: fuelupgrade
tags: added: fuelupgrade
Changed in fuel:
importance: Medium → High
Evgeniy L (rustyrobot)
Changed in fuel:
status: New → Confirmed
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104266

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/104266
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=6642480412c48016b0776575d0704f2cbc2288b8
Submitter: Jenkins
Branch: master

commit 6642480412c48016b0776575d0704f2cbc2288b8
Author: Evgeniy L <email address hidden>
Date: Wed Jul 2 21:09:53 2014 +0400

    Upgrades, changed workflow for versions.yaml config file

    Now we have the next worflow
    * if user runs upgrade script first time,
      we save current version.yaml file into
      work directory
    * if user for some reaons runs the script
      second or third time, we use version.yaml
      from work directory as the version which
      we need to rollback to, we cannot use
      config from /etc/fuel/version.yaml.
      Because upgrade script could be
      interrupted after symlink creation

    Additional fixes
    * config has version parameters which looks
      like strings instead of dicts with hierarchy,
      because we don't need all of the data from
      version.yaml file
    * removed before and post upgrade section
      because they were useless, in fact we
      can do this actions in upgrade method
    * created before upgrade checker which is
      activated only if the script was ran
      with docker parameter, this checker
      checks if ugprade make sense. For example
      now impossible to run upgrade from version
      5.0 to 5.0 and from 5.1 to 5.0.1

    blueprint upgrade-to-5-1
    Closes-bug: #1331363
    Closes-bug: #1333584
    Change-Id: I719799db216260d527ce5e9be2f03acc234cf3b0

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/104567

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/5.0)

Reviewed: https://review.openstack.org/104567
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=d01b4efc0fc4af9d0e316b9dfc7974f16975f822
Submitter: Jenkins
Branch: stable/5.0

commit d01b4efc0fc4af9d0e316b9dfc7974f16975f822
Author: Evgeniy L <email address hidden>
Date: Wed Jul 2 21:09:53 2014 +0400

    Upgrades, changed workflow for versions.yaml config file

    Now we have the next worflow
    * if user runs upgrade script first time,
      we save current version.yaml file into
      work directory
    * if user for some reaons runs the script
      second or third time, we use version.yaml
      from work directory as the version which
      we need to rollback to, we cannot use
      config from /etc/fuel/version.yaml.
      Because upgrade script could be
      interrupted after symlink creation

    Additional fixes
    * config has version parameters which looks
      like strings instead of dicts with hierarchy,
      because we don't need all of the data from
      version.yaml file
    * removed before and post upgrade section
      because they were useless, in fact we
      can do this actions in upgrade method
    * created before upgrade checker which is
      activated only if the script was ran
      with docker parameter, this checker
      checks if ugprade make sense. For example
      now impossible to run upgrade from version
      5.0 to 5.0 and from 5.1 to 5.0.1

    blueprint upgrade-to-5-0-1
    Closes-bug: #1331363
    Closes-bug: #1333584
    Change-Id: I719799db216260d527ce5e9be2f03acc234cf3b0

Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

verified on
{

    "build_id": "2014-09-09_00-01-11",
    "ostf_sha": "f7b5d9d0d1cfaba5f1fe1e2c634493e92bce11db",
    "build_number": "505",
    "auth_required": true,
    "api": "1.0",
    "nailgun_sha": "7683df5722975c1cae48a1a3efdad872b4aaace6",
    "production": "docker",
    "fuelmain_sha": "6cdd8c3deaa5e52806a5c75c4177f3b41d157a22",
    "astute_sha": "b622d9b36dbdd1e03b282b9ee5b7435ba649e711",
    "feature_groups": [
        "mirantis"
    ],
    "release": "5.1",
    "release_versions": {
        "2014.1.1-5.0.1": {
            "VERSION": {
                "build_id": "2014-08-14_19-52-36",
                "mirantis": "yes",
                "build_number": "170",
                "ostf_sha": "09b6bccf7d476771ac859bb3c76c9ebec9da9e1f",
                "nailgun_sha": "af3d1922bfc21345f81be3454115ab6139675c35",
                "production": "docker",
                "api": "1.0",
                "fuelmain_sha": "fd58828f404e4298ed338e8f44c6a326cebd31de",
                "astute_sha": "6db5f5031b74e67b92fcac1f7998eaa296d68025",
                "release": "5.0.1",
                "fuellib_sha": "a31dbac8fff9cf6bc4cd0d23459670e34b27a9ab"
            }
        },
        "2014.1.1-5.0.2": {
            "VERSION": {
                "build_id": "2014-09-08_15-45-27",
                "ostf_sha": "2969c1ad443b632e815bb1f01149c3800cd7aa3a",
                "build_number": "71",
                "api": "1.0",
                "nailgun_sha": "c18a21381843dffe807b254a4ff96eec259953cb",
                "production": "docker",
                "fuelmain_sha": "b1e46c8c3ac86a8eafac225507294226322160ea",
                "astute_sha": "6db5f5031b74e67b92fcac1f7998eaa296d68025",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "5.0.2",
                "fuellib_sha": "c891490242d7d88f3c9582cf023e8f2db0b9d337"
            }
        },
        "2014.1.1-5.1": {
            "VERSION": {
                "build_id": "2014-09-09_00-01-11",
                "ostf_sha": "f7b5d9d0d1cfaba5f1fe1e2c634493e92bce11db",
                "build_number": "505",
                "api": "1.0",
                "nailgun_sha": "7683df5722975c1cae48a1a3efdad872b4aaace6",
                "production": "docker",
                "fuelmain_sha": "6cdd8c3deaa5e52806a5c75c4177f3b41d157a22",
                "astute_sha": "b622d9b36dbdd1e03b282b9ee5b7435ba649e711",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "5.1",
                "fuellib_sha": "203ef3179007cffe3236032e61ecbaf1cd20605f"
            }
        }
    },
    "fuellib_sha": "203ef3179007cffe3236032e61ecbaf1cd20605f"

}

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.