SQLAlchemy >= 0.9.5 breaks tests

Bug #1333556 reported by Thomas Herve
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Critical
Thomas Herve

Bug Description

We're getting a lot of test failures since yesterday night ending up with "TypeError: 'NoneType' object does not support item assignment" during update code. I tracked it down to the new SQLAlchemy releases, trying to understand what's going on.

Revision history for this message
Thomas Herve (therve) wrote :

I found the issue, it has to do with MutableDict, opened https://bitbucket.org/zzzeek/sqlalchemy/issue/3093/mutabledictsetdefault-doesnt-return-the upstream.

Revision history for this message
Liusheng (liusheng) wrote :

this bug just need Updating the requirements from global requirements, like: https://review.openstack.org/#/c/96819/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102155

Changed in heat:
status: New → In Progress
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

Liusheng, it will not help as SQLAlchemy 0.9.6 is already on PYPI, it still has this problem, but global requirements only blacklist 0.9.5

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/102155
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=8e7294a7c3178222f94ce1cea45d77d70d5ac95e
Submitter: Jenkins
Branch: master

commit 8e7294a7c3178222f94ce1cea45d77d70d5ac95e
Author: Thomas Herve <email address hidden>
Date: Tue Jun 24 11:31:46 2014 +0200

    Don't rely on setdefault returning a value

    Workaround a bug in sqlalchemy>=0.9.5 where setdefault doesn't return
    the proper value.

    Change-Id: Ibc93024f7f41f4ced81525fac42566a18b1c641c
    Closes-Bug: #1333556

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
Matt Riedemann (mriedem) wrote :
Revision history for this message
Matt Riedemann (mriedem) wrote :

Nevermind comment 6, looks like maybe my change got caught up before the fix was merged to heat.

Revision history for this message
Matt Riedemann (mriedem) wrote :

I don't think this is a duplicate of bug 1333410, that was for a different kind of error introduced with sqla 0.9.5.

Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.