Cinder

inconsistent string encoding in rbd driver

Bug #1333446 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Edward Hope-Morley
Cinder 2014.2 "juno"

Bug Description

The Cinder RBD driver encodes string args used with librbd to ensure they are utf-8 since librbd breaks with formats like unicode. The means by which this encoding is performed/checked in the driver is inconsistent e.g. some methods cast to str(), some to ascii_str() and some to stutils.safe_encode(). The lattermost should be used in all cases i.e. strutils.safe_encode().

See original description
Tags: ceph drivers
Edward Hope-Morley (hopem)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102038

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/102038
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=20001f2470fbc7e03a0f2a19d62b6b0ef38e9657
Submitter: Jenkins
Branch: master

commit 20001f2470fbc7e03a0f2a19d62b6b0ef38e9657
Author: Edward Hope-Morley <email address hidden>
Date: Mon Jun 23 17:51:44 2014 +0100

    Make rbd driver string encoding checks consistent

    All string checks should use strutils.safe_encode()

    Closes-Bug: 1333446
    Change-Id: I56c9ccbcedd34c83793620561da17c47cb5f551c

Changed in cinder:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.