OpenStack Heat

Excessive limits validation in OS::Nova::Server for maxPersonality limit

Bug #1333283 reported by Serg Melikyan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Serg Melikyan
OpenStack Heat 2014.2 "juno"
Icehouse
Fix Released
Undecided
Unassigned
OpenStack Heat 2014.1.4

Bug Description

We have PERSONALITY property on OS::Nova::Server that defaults to {}, but code that triggers check for limits compares value of property to None -> this property always got validated for limits.

In conjunction with bug #1310710 causes:
StackValidationFailed: The personality property may not contain greater than -1 entries

Serg Melikyan (smelikyan)
Changed in heat:
assignee: nobody → Serg Melikyan (smelikyan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/101926

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/101926
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=78b68ba0da5d6ad71397538e484fb7565333129b
Submitter: Jenkins
Branch: master

commit 78b68ba0da5d6ad71397538e484fb7565333129b
Author: Serg Melikyan <email address hidden>
Date: Mon Jun 23 19:00:40 2014 +0400

    Prevent excessive validation for maxPersonality limit

    We have PERSONALITY property on OS::Nova::Server that defaults to {},
    but code that triggers check for limits compares value of property
    to None -> this property always get validated for limits (if limit is
    set).

    Change-Id: I552a03cd9f4ab570aa059349ab361bb50c9c0d1e
    Closes-bug: #1333283

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/116279

Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/icehouse)

Reviewed: https://review.openstack.org/116279
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=006b95949ca532abe6a4d2de2da144e995190452
Submitter: Jenkins
Branch: stable/icehouse

commit 006b95949ca532abe6a4d2de2da144e995190452
Author: Ethan Lynn <email address hidden>
Date: Fri Aug 22 13:50:36 2014 +0800

    Prevent excessive validation for maxPersonality limit

    We have PERSONALITY property on OS::Nova::Server that defaults to {},
    but code that triggers check for limits compares value of property
    to None -> this property always get validated for limits (if limit is
    set).

    Change-Id: I552a03cd9f4ab570aa059349ab361bb50c9c0d1e
    Closes-bug: #1333283
    (cherry picked from commit 78b68ba0da5d6ad71397538e484fb7565333129b)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.