Glance image delete output

[Tzach Shefi]

Description of problem: Deleting a none existing image should always return same output.

Version-Release number of selected component (if applicable):
RHEL7
openstack-glance-2014.1-4.el7ost.noarch
python-glanceclient-0.12.0-1.el7ost.noarch
python-glance-2014.1-4.el7ost.noarch

How reproducible:
Every time

Steps to Reproduce:
1. Upload a test image glance image-create ...
2. Glance image-list note new image's ID
3. Delete that same image glance image-delete <imageID>
3. Note output ->
Request returned failure status.
404 not found
Image 07169a6f-bbce-4879-97d9-904fd69bb174 not found.
    (HTTP 404): Unable to delete image 07169a6f-bbce-4879-97d9-904fd69bb174

4. Now delete a none existing image glance image-delete <fakeImageID>
5. Output ->
Request returned failure status.
No image with a name or ID of '07169a6f-bbce-4879-97d9-904fd69bb179' exists.

Actual results:
See step 3 / 5 each one returns another output

Expected results:
It would be better if both deletions would return same output. Preferably this one -> No image with a name or ID of '....' exists.

From a user's stand point deleting a none existing image should always return same output, the fact that one of the images still has a DB listing which causes a different output is a bit misleading for someone not familiar with system's inner workings. If this unique output is a must maybe improve wording, "No image with name of ID.... exists, but there is an old listing in DB for it.. "

[Tzach Shefi (tshefi)]

Glance api.log it's a shared system not a clean log, sorry about that.

[Kent Wang (k.wang)]

Hi I wasn't able to reproduce step 3. There's no output on a successful deletion. Are you on the latest release?

[Tzach Shefi (tshefi)]

Hey Kent,

That's correct no error on image deletion, notice you were supposed to run that deletion command twice :)
See below step 3 to delete image (deleted no output), step 4 try to delete that same image you just deleted on step 3, only then do you get the misleading notice.

Glance version used:
openstack-glance-2014.1-4.el7ost.noarch
python-glanceclient-0.12.0-1.el7ost.noarch
python-glance-2014.1-4.el7ost.noarch

1. Uploaded an image
2. Image list to get it's ID

[root@puma31 ~(keystone_admin)]# glance image-list
+--------------------------------------+-------------+-------------+------------------+-----------+--------+
| ID | Name | Disk Format | Container Format | Size | Status |
+--------------------------------------+-------------+-------------+------------------+-----------+--------+
| fa3406fa-ecef-44b8-a8e1-347203e40501 | twotwo | qcow2 | bare | 416309760 | active |
+--------------------------------------+-------------+-------------+------------------+-----------+--------+

3. Now delete that image, should work deleting the image as it should.

[root@puma31 ~(keystone_admin)]# glance image-delete fa3406fa-ecef-44b8-a8e1-347203e40501

4. Run exact same deletion command again, image delete will fail as no image is left to delete, yet notice reasoning.

[root@puma31 ~(keystone_admin)]# glance image-delete fa3406fa-ecef-44b8-a8e1-347203e40501
Request returned failure status.
404 Not Found
Image fa3406fa-ecef-44b8-a8e1-347203e40501 not found.
    (HTTP 404): Unable to delete image fa3406fa-ecef-44b8-a8e1-347203e40501

5. Now delete another image, this time use a fake none existing image ID

[root@puma31 ~(keystone_admin)]# glance image-delete fa3406fa-ecef-44b8-a8e1-347203e40522
Request returned failure status.
No image with a name or ID of 'fa3406fa-ecef-44b8-a8e1-347203e40522' exists.

My point being, compare outputs from steps 4 and 5.
Hope this clears things up.

[Rajani Srivastava (srivastava-rajani)]

Patch Submitted at :

https://review.openstack.org/#/c/109918/

[Dolph Mathews (dolph)]

(given that the proposed fix has not merged, the correct status is still In Progress)

[Kamil Rykowski (kamil-rykowski)]

Fix proposed to branch: master
Review: https://review.openstack.org/140988

[Abhishek Talwar (abhishek-talwar)]

Hi Kamil,

Thanks for co-authoring on my bug and adding the test cases. But I would like you to reassign this bug to me as I have been working on this from a long time.
So kindly re-assign it to me and we can get it merged together.

Thanks and Regards
Abhishek Talwar

[Kamil Rykowski (kamil-rykowski)]

Reviewed & merged: https://review.openstack.org/#/c/140988/