Pushing to svn fails because of attempt to use an incorrect root directory (?)

[Lukáš Lalinský]

In this one I'm really not sure about the right fix. If I do:

bzr push http://svn.musicbrainz.org/mb_server/branches/StructuredXHTML

I get an error:

PROPFIND request failed on '/branches'

I've found out it tries to open directories in this order:

root = open_root()
a = open_directory(root, "mb_server/branches")
b = open_directory(a, "mb_server/branches/StructuredXHTML")

while according to http://svn.collab.net/svn-doxygen/group__svn__delta__tree__deltas.html it should do:

root = open_root()
a = open_directory(root, "mb_server")
b = open_directory(a, "mb_server/branches")
c = open_directory(b, "mb_server/branches/StructuredXHTML")

Changing this works for me, but I'm not sure what it was 1 originally:

         # Open paths leading up to branch
- for i in range(1, len(elements)-1):
+ for i in range(0, len(elements)-1):
             # Does directory already exist?
             ret.append(self.editor.open_directory(
                 "/".join(existing_elements[0:i+1]), ret[-1], -1, self.pool))

[Lukáš Lalinský (luks)]

Hm, using the 0.4 branch push always fails with:

python: /build/buildd/subversion-1.4.3dfsg1/subversion/libsvn_subr/path.c:377: svn_path_basename: Assertion `is_canonical(path, len)' failed.

Is there something wrong about the SVN URL?

[Jelmer Vernooij (jelmer)]

It was 1 originally by mistake - svn://, svn+ssh:// and file:// happily
open nested directories so I hadn't noticed.

I've applied your patch, thanks.

  status fixcommitted
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>