AddrFormatError: failed to detect a valid IP address from None executing upload_dhcp_leases task

Bug #1332596 reported by Diogo Matsubara
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Raphaël Badin

Bug Description

As seen here: http://d-jenkins.ubuntu-ci:8080/view/MAAS/job/utopic-adt-maas-manual/43/artifact/results/artifacts/maas-logs/var/log/maas/celery.log/*view*/

The cluster controller sends the upload_dhcp_leases task but that fails with:

[2014-06-20 10:58:26,891: ERROR/MainProcess] Task provisioningserver.tasks.upload_dhcp_leases[158c6ce2-8b66-4d74-aa3d-48f11241bb5a] raised unexpected: IOError()
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/celery/app/trace.py", line 240, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/celery/app/trace.py", line 437, in __protected_call__
    return self.run(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/tasks.py", line 98, in wrapper
    func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/tasks.py", line 314, in upload_dhcp_leases
    upload_leases()
  File "/usr/lib/python2.7/dist-packages/provisioningserver/dhcp/leases.py", line 192, in upload_leases
    process_leases(timestamp, leases)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/dhcp/leases.py", line 178, in process_leases
    send_leases(leases)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/dhcp/leases.py", line 172, in send_leases
    api_path, 'update_leases', leases=json.dumps(leases))
  File "/usr/lib/python2.7/dist-packages/apiclient/maas_client.py", line 232, in post
    url, method="POST", headers=headers, data=body)
  File "/usr/lib/python2.7/dist-packages/apiclient/maas_client.py", line 113, in dispatch_query
    res = urllib2.urlopen(req)
  File "/usr/lib/python2.7/urllib2.py", line 127, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 410, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 448, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError

And http://d-jenkins.ubuntu-ci:8080/view/MAAS/job/utopic-adt-maas-manual/43/artifact/results/artifacts/maas-logs/var/log/maas/maas.log/*view*/

ERROR 2014-06-20 10:58:26,732 maasserver ################################ Exception: failed to detect a valid IP address from None ################################
ERROR 2014-06-20 10:58:26,825 maasserver Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/dist-packages/django/views/decorators/vary.py", line 19, in inner_func
    response = func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/piston/resource.py", line 167, in __call__
    result = self.error_handler(e, request, meth, em_format)
  File "/usr/lib/python2.7/dist-packages/piston/resource.py", line 165, in __call__
    result = meth(request, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/maasserver/api_support.py", line 189, in dispatch
    return function(self, request, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/maasserver/api.py", line 1688, in update_leases
    update_mac_cluster_interfaces(leases, nodegroup)
  File "/usr/lib/python2.7/dist-packages/maasserver/api.py", line 1527, in update_mac_cluster_interfaces
    interface.ip_range_low, interface.ip_range_high)
  File "/usr/lib/python2.7/dist-packages/netaddr/ip/__init__.py", line 1289, in __init__
    self._start = IPAddress(start, flags=flags)
  File "/usr/lib/python2.7/dist-packages/netaddr/ip/__init__.py", line 315, in __init__
    'address from %r' % addr)
AddrFormatError: failed to detect a valid IP address from None

Tags: ci

Related branches

tags: added: ci
Raphaël Badin (rvb)
Changed in maas:
importance: Undecided → Critical
status: New → Triaged
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Graham, could this be related to your recent changes? This has been pretty solid up until now.

Revision history for this message
Raphaël Badin (rvb) wrote :

Looks like we're not checking that an interface is actually configured before we use it in update_mac_cluster_interfaces().

Changed in maas:
assignee: nobody → Raphaël Badin (rvb)
status: Triaged → In Progress
Raphaël Badin (rvb)
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
milestone: none → 1.6.0
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.