Could not send notification to notifications

Bug #1332412 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Ihar Hrachyshka

Bug Description

"Could not send notification to notifications" errors started happening today.
probably due to oslo.messaging changes.

2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging Traceback (most recent call last):
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/notify/_impl_messaging.py", line 47, in notify
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging version=self.version)
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/transport.py", line 96, in _send_notification
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging self._driver.send_notification(target, ctxt, message, version)
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqpdriver.py", line 394, in send_notification
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging envelope=(version == 2.0), notify=True)
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqpdriver.py", line 355, in _send
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging rpc_amqp.pack_context(msg, context)
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/_drivers/amqp.py", line 212, in pack_context
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging context_d = six.iteritems(context.to_dict())
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging File "/usr/local/lib/python2.7/dist-packages/six.py", line 553, in iteritems
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging return iter(d.iteritems(**kw))
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging AttributeError: 'Context' object has no attribute 'iteritems'
2014-06-20 13:00:54.239 TRACE oslo.messaging.notify._impl_messaging

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOiBcIkNvdWxkIG5vdCBzZW5kIG5vdGlmaWNhdGlvbiB0byBub3RpZmljYXRpb25zXCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjE3MjgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0MDMyNDIyNjczOTd9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/101459

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Changed in neutron:
assignee: YAMAMOTO Takashi (yamamoto) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by YAMAMOTO Takashi (<email address hidden>) on branch: master
Review: https://review.openstack.org/101459
Reason: i prefer https://review.openstack.org/101485

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/101485
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=48e9c8b79bea9c9a65ceb1c24528a89db6d313d2
Submitter: Jenkins
Branch: master

commit 48e9c8b79bea9c9a65ceb1c24528a89db6d313d2
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Jun 20 13:29:06 2014 +0200

    Pass serializer to oslo.messaging Notifier

    oslo.messaging has a workaround [1] that requires context to be
    transformed to pure dict before passing into amqpdriver.

    Renamed serializer class to reflect its broader usage.

    Updated FakeNotifier to expect serializer and other keyword arguments
    supported by oslo.messaging Notifier class.

    [1]: oslo/messaging/_drivers/amqpdriver.py#L337

    blueprint oslo-messaging

    Closes-Bug: #1332412
    Change-Id: I7e7658d03639afae7bf6d3ad71445cb5b6459c09

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.