Poor exception message on missing default datastore

[Denis M.]

trove create mysql 2 --size 2

ERROR: Datastore 'mysql' cannot be found. (HTTP 400)

This message seems poor and doesn't describe issue that happend. Need to say that there's no default datastore. Instead of including specific datastore into a response.

[Amrith Kumar (amrith)]

Updating importance to "Wishlist" (bugscrub, 2014-10-23)

[Andy Hsiang (yh418t)]

Hi, are you sure you do not have the default datastore defined in your trove.conf file? when I comment out the line in the trove.conf where the default datastore was set, it gives me "ERROR: Please specify datastore. Default datastore cannot be found. (HTTP 400). The error message datastore mysql cannot be found is appropriate if i set the default datastore to mysql in the trove.conf file.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/331136

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/331136
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=74804acd3a843c2133db8d87dab2c947909f60eb
Submitter: Jenkins
Branch: master

commit 74804acd3a843c2133db8d87dab2c947909f60eb
Author: Trevor McCasland <email address hidden>
Date: Fri Jun 17 08:12:15 2016 -0500

    Use correct message for missing default datastore

    The error message when trying to create an instance
    with a non-existent default datastore was misleading:

    ERROR: Datastore 'mysql' cannot be found. (HTTP 400)

    This is now more descriptive:

    ERROR: Please specify datastore. Default datastore 'mysql' cannot be
    found. (HTTP 400)

    If no default datastore is defined, the message is:

    ERROR: Please specify datastore. No default datastore is defined. (HTTP
    400)

    If the user specified a datastore, then the regular error
    message is returned.

    A new exception DatastoreDefaultDatastoreNotDefined was created
    and DatastoreDefaultDatastoreNotFound modified to take 'datastore'
    as an argument.

    Change-Id: I0b7856864bfecfe3173e42cf098ad759ec8334a2
    Closes-Bug: #1331408

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/trove 6.0.0.0b2 development milestone.