parametrize table_prefix_separator in hbase connection

Bug #1331374 reported by Stefano Zilli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Stefano Zilli

Bug Description

Currently table_prefix_separator is hardcoded to be an underscore. It should be nice to have it customizable.

Something like:
connection = hbase://localhost:9090/?table_prefix=ceilo&table_prefix_separator=.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100829

Changed in ceilometer:
assignee: nobody → Stefano Zilli (stefano-zilli)
status: New → In Progress
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → juno-2
importance: Undecided → Low
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: juno-2 → juno-3
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-3 → juno-rc1
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: juno-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (master)

Change abandoned by Stefano Zilli (<email address hidden>) on branch: master
Review: https://review.openstack.org/100829

Revision history for this message
Lianhao Lu (lianhao-lu) wrote :

Seems like Stefano Zilli abandoned the effort?

Changed in ceilometer:
status: In Progress → Triaged
assignee: Stefano Zilli (stefano-zilli) → nobody
Revision history for this message
Stefano Zilli (szilli) wrote :

Tbh I've got discouraged when my patch was discarded because it was adding a random separator to an already random generated table name (uuid4) in the unit tests (for me adding random to random is still random) and decided to wait. I'm actually still maintaining the patch and using it in production. Maybe I will propose a new fix this time adding something similar to the new prefix string os.getenv("CEILOMETER_TEST_HBASE_TABLE_PREFIX", "test") in the unit tests.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/228363

Changed in ceilometer:
assignee: nobody → Stefano Zilli (stefano-zilli)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/228363
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=3ae2e054ac7338077f364577bc624f917e0d508a
Submitter: Jenkins
Branch: master

commit 3ae2e054ac7338077f364577bc624f917e0d508a
Author: Stefano Zilli <email address hidden>
Date: Mon Sep 28 09:12:44 2015 +0200

    Parametrize table_prefix_separator in hbase

    table_prefix_separator is hardcoded to be an underscore (happybase
    default). This fix adds the possibility to parametrize this value using
    a parameter in ceilometer database configuration. An example is:
    hbase://localhost:9090/?table_prefix=ceilo&table_prefix_separator=.

    Change-Id: I8c3c2a0b35001991844e679282ffd0ee4ae76abc
    Closes-Bug: #1331374

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/ceilometer 6.0.0.0b1

This issue was fixed in the openstack/ceilometer 6.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.