Need to make sure msgpack-python version >= 0.4.0

Bug #1331280 reported by Feilong Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Critical
Feilong Wang

Bug Description

Now we're depending on msgpack, but we didn't specify what version we're relaying on. However, Marconi code is using some new features introdcued [1,2,3] in msgpack 0.4.0, so if user are using the version under that, they may run into below error[4] and see HTTP 503 code.

[1]https://github.com/openstack/marconi/blob/master/marconi/common/decorators.py#L117

[2] https://pypi.python.org/pypi/msgpack-python

[3] https://github.com/openstack/marconi/blob/master/requirements.txt#L8

[4] =====
2014-06-18 13:52:40.871 6160 ERROR marconi.queues.transport.wsgi.v1_0.stats [-] packb() got an unexpected keyword argument 'use_bin_type'
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats Traceback (most recent call last):
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/queues/transport/wsgi/v1_0/stats.py", line 38, in on_get
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats project=project_id)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/common/pipeline.py", line 99, in consumer
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats result = target(*args, **kwargs)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/queues/storage/mongodb/utils.py", line 253, in wrapper
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats return func(*args, **kwargs)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/queues/storage/mongodb/utils.py", line 285, in wrapper
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats return func(self, *args, **kwargs)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/queues/storage/mongodb/queues.py", line 283, in stats
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats if not self.exists(name, project=project):
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/queues/storage/mongodb/utils.py", line 253, in wrapper
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats return func(*args, **kwargs)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/queues/storage/mongodb/utils.py", line 285, in wrapper
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats return func(self, *args, **kwargs)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "/home/feilong/MyWorkSpace/workspace_community/marconi/marconi/common/decorators.py", line 117, in wrapper
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats packed_value = msgpack.packb(value, use_bin_type=True)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats File "_packer.pyx", line 254, in msgpack._packer.packb (msgpack/_packer.cpp:254)
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats TypeError: packb() got an unexpected keyword argument 'use_bin_type'
2014-06-18 13:52:40.871 6160 TRACE marconi.queues.transport.wsgi.v1_0.stats
127.0.0.1 - - [18/Jun/2014 13:52:40] "GET /v1/queues/flwang_1/stats HTTP/1.1" 503 138

Feilong Wang (flwang)
Changed in marconi:
importance: Undecided → Critical
assignee: nobody → Fei Long Wang (flwang)
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to marconi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100745

Changed in marconi:
status: New → In Progress
Feilong Wang (flwang)
summary: - Need to make sure msgpack-python version >= 0.4.2
+ Need to make sure msgpack-python version >= 0.4.0
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on marconi (master)

Change abandoned by Fei Long Wang (<email address hidden>) on branch: master
Review: https://review.openstack.org/100745
Reason: it's synced by robot.

Kurt Griffiths (kgriffs)
Changed in marconi:
status: In Progress → Fix Committed
Changed in marconi:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.