workflow default success/error messaging bug

[Cindy Lu]

Default workflow success and failure messages are:

success_message = _("%s completed successfully.")
failure_message = _("%s did not complete.")
https://github.com/openstack/horizon/blob/master/horizon/workflows/base.py#L595

According to the class definition, failure message is supposed to be: "{{ workflow.name }} did not complete."

However, it ends up using the row.name and appearing as "demo did not complete."

When it should be "Edit project did not complete".

Please see attachment.

You can try this out for yourself by going to /admin/projects/workflows.py (https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/projects/workflows.py#L346)
and commenting out the two success and failure messages.

[Lin Hua Cheng (lin-hua-cheng)]

removing assignee, no activity for a year

[David Cusatis (dcusati)]

I'm not sure this bug is valid anymore because this file no longer exists - https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/projects/workflows.py#L346

and the UI has changed such that the Admin panel no longer has a project tab, so I am unable to reproduce this bug.