Big Switch: Uneccesary init method and server_timeout param

Bug #1331249 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kevin Benton
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

Both the Big Switch Plugin and ML2 driver allow a server_timeout param in the initialization methods that can never be set by a user so it doesn't serve a purpose [1][2]. With those removed, the entire __init__ method of the base class can be removed as well.

1. https://github.com/openstack/neutron/blob/d379170109982a53544d01566ba9231d66b24ed4/neutron/plugins/bigswitch/plugin.py#L171
2. https://github.com/openstack/neutron/blob/1a116d24a955c9e45fa8a29998d09da0350be4ab/neutron/plugins/ml2/drivers/mech_bigswitch/driver.py#L46

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100731

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Changed in neutron:
importance: Undecided → Low
milestone: none → juno-2
tags: added: bigswitch
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/100731
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=24a19bfd362996cd9833a167d6eb86fdcf743b75
Submitter: Jenkins
Branch: master

commit 24a19bfd362996cd9833a167d6eb86fdcf743b75
Author: Kevin Benton <email address hidden>
Date: Thu Jun 12 02:15:27 2014 -0700

    Big Switch: Remove unnecessary initialization code

    Removes a server_timeout parameter that was never set by anything
    in the Big Switch plugin and the ML2 driver.

    Also eliminates an __init__ method that didn't do anything except
    incorrectly log an unset server pool warning before the inheriting
    class setup the server pool.

    Closes-Bug: #1331249
    Change-Id: I77dd22295305b96d4702f1ea0e319dc5f82c71a8

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/101434

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/101434
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e517da2dbe1d12acbd8ea217e4f1b7b8b4403eb8
Submitter: Jenkins
Branch: stable/icehouse

commit e517da2dbe1d12acbd8ea217e4f1b7b8b4403eb8
Author: Kevin Benton <email address hidden>
Date: Thu Jun 12 02:15:27 2014 -0700

    Big Switch: Remove unnecessary initialization code

    Removes a server_timeout parameter that was never set by anything
    in the Big Switch plugin and the ML2 driver.

    Also eliminates an __init__ method that didn't do anything except
    incorrectly log an unset server pool warning before the inheriting
    class setup the server pool.

    Closes-Bug: #1331249
    Change-Id: I77dd22295305b96d4702f1ea0e319dc5f82c71a8
    (cherry picked from commit 24a19bfd362996cd9833a167d6eb86fdcf743b75)

tags: added: in-stable-icehouse
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.