[api] is_public defaults to true, and anyone can create a public package

[Steve McLellan]

is_public defaults to true in the database model for packages and there's nothing controlling who can create public packages at present.

Glance treats is_public as a special property that triggers an additional policy check (publicize_image) that is typically restricted to admins (and as of Juno will be by default restricted to admins - https://wiki.openstack.org/wiki/OSSN/OSSN-0015). I suggest following the same pattern, and making the property default.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109153

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109153
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=f5daa12347268a53fafae08cff285a76b3abdf93
Submitter: Jenkins
Branch: master

commit f5daa12347268a53fafae08cff285a76b3abdf93
Author: Steve McLellan <email address hidden>
Date: Wed Jul 23 18:27:57 2014 -0500

    Default is_public to false

    Sets is_public=false in the database model, adds is_public querystring
    to API and policy check for it. Will need corresponding client change.

    Does not include an alembic migration because altering columns is
    apparently difficult, and removing/adding does more damage than good.
    New objects should have is_public set to False by the db model.

    Relies on changes in https://review.openstack.org/#/c/109151/ (mainly
    for unit test refactoring).

    Change-Id: I390806b7e2d09f18ab3c496178406e1a3fc8d899
    Closes-Bug: #1331243