Forbid SDL integer types in codecheck and remove its use
Bug #1330599 reported by
SirVer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
SDL defines its own integer types (e.g. Uint32). We have stdint.h though which defines them on a lower level (e.g. uint32_t). We should remove the SDL types from our code base and use stdint.h for everything.
Also, we should add a codecheck rule that forbids them everywhere (we already have one that forbids using them in code that does not include SDL) so that they do not come back.
Related branches
lp:~widelands-dev/widelands/bug-1330599
- SirVer: Approve
-
Diff: 1479 lines (+200/-179)56 files modifiedcmake/codecheck/rules/do_not_use_SDL_int (+22/-0)
src/editor/editorinteractive.cc (+2/-2)
src/editor/editorinteractive.h (+2/-2)
src/graphic/color.cc (+2/-2)
src/graphic/colormap.cc (+2/-2)
src/graphic/image_transformations.cc (+2/-2)
src/graphic/render/gamerenderer_sdl.cc (+9/-9)
src/graphic/render/minimaprenderer.cc (+13/-13)
src/graphic/render/sdl_helper.cc (+1/-1)
src/graphic/render/sdl_surface.cc (+24/-24)
src/graphic/render/sdl_surface.h (+1/-1)
src/graphic/render/terrain_sdl.h (+3/-3)
src/graphic/text/sdl_ttf_font.cc (+3/-3)
src/graphic/texture.cc (+2/-2)
src/sound/fxset.h (+2/-2)
src/sound/sound_handler.cc (+1/-1)
src/ui_basic/button.cc (+3/-3)
src/ui_basic/button.h (+3/-3)
src/ui_basic/checkbox.cc (+3/-3)
src/ui_basic/checkbox.h (+3/-3)
src/ui_basic/editbox.cc (+2/-2)
src/ui_basic/editbox.h (+2/-2)
src/ui_basic/listselect.cc (+3/-3)
src/ui_basic/listselect.h (+3/-3)
src/ui_basic/messagebox.cc (+2/-2)
src/ui_basic/messagebox.h (+2/-2)
src/ui_basic/multilinetextarea.cc (+1/-1)
src/ui_basic/multilinetextarea.h (+1/-1)
src/ui_basic/panel.cc (+9/-9)
src/ui_basic/panel.h (+9/-9)
src/ui_basic/scrollbar.cc (+3/-3)
src/ui_basic/scrollbar.h (+3/-3)
src/ui_basic/slider.cc (+5/-5)
src/ui_basic/slider.h (+5/-5)
src/ui_basic/table.cc (+2/-2)
src/ui_basic/table.h (+4/-4)
src/ui_basic/tabpanel.cc (+3/-3)
src/ui_basic/tabpanel.h (+3/-3)
src/ui_basic/window.cc (+3/-3)
src/ui_basic/window.h (+3/-3)
src/ui_fsmenu/intro.cc (+2/-2)
src/ui_fsmenu/intro.h (+2/-2)
src/wlapplication.cc (+1/-1)
src/wlapplication.h (+3/-4)
src/wui/game_summary.cc (+1/-1)
src/wui/game_summary.h (+1/-1)
src/wui/game_tips.cc (+1/-1)
src/wui/mapview.cc (+3/-3)
src/wui/mapview.h (+3/-3)
src/wui/minimap.cc (+2/-2)
src/wui/minimap.h (+2/-2)
src/wui/soldierlist.cc (+4/-4)
src/wui/story_message_box.cc (+1/-1)
src/wui/story_message_box.h (+1/-1)
src/wui/waresdisplay.cc (+1/-1)
src/wui/waresdisplay.h (+1/-1)
Changed in widelands: | |
milestone: | none → build19-rc1 |
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
status: | Confirmed → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
Changed in widelands: | |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in build19-rc1.