widelands

Forbid SDL integer types in codecheck and remove its use

Bug #1330599 reported by SirVer on 2014-06-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Fix Released	Low	Unassigned	widelands build19-rc1

Bug Description

SDL defines its own integer types (e.g. Uint32). We have stdint.h though which defines them on a lower level (e.g. uint32_t). We should remove the SDL types from our code base and use stdint.h for everything.

Also, we should add a codecheck rule that forbids them everywhere (we already have one that forbids using them in code that does not include SDL) so that they do not come back.

Tags:

Related branches

lp:~widelands-dev/widelands/bug-1330599

Merged into lp:widelands at revision 7079

SirVer: Approve on 2014-07-14

SirVer (sirver) on 2014-06-17

Changed in widelands:
milestone:	none → build19-rc1

GunChleoc (gunchleoc) on 2014-07-13

Changed in widelands:
assignee:	nobody → GunChleoc (gunchleoc)
status:	Confirmed → In Progress

SirVer (sirver) on 2014-07-14

Changed in widelands:
status:	In Progress → Fix Committed

GunChleoc (gunchleoc) on 2016-02-21

Changed in widelands:
assignee:	GunChleoc (gunchleoc) → nobody

GunChleoc (gunchleoc) on 2016-10-25

Changed in widelands:
status:	Fix Committed → Fix Released

Revision history for this message

GunChleoc (gunchleoc) wrote on 2016-10-25:

Fixed in build19-rc1.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.