Wrong assertions in unittests using mock
Bug #1330391 reported by
Valeriy Ponomaryov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Medium
|
Valeriy Ponomaryov |
Bug Description
mock objects don't have method "assert_
manila/
manila/
manila/
manila/
manila/
manila/
So, these test modules should be rewritten properly using next methods:
assert_any_call
assert_
assert_called_with
assert_has_calls
Changed in manila: | |
importance: | Undecided → Medium |
Changed in manila: | |
milestone: | none → juno-2 |
summary: |
- Wrong assertions in unittests + Wrong assertions in unittests using mock |
description: | updated |
Changed in manila: | |
milestone: | juno-2 → kilo-1 |
Changed in manila: | |
assignee: | nobody → venkata anil (anil-venkata) |
Changed in manila: | |
status: | New → In Progress |
Changed in manila: | |
assignee: | venkata anil (anil-venkata) → nobody |
status: | In Progress → New |
Changed in manila: | |
assignee: | nobody → Valeriy Ponomaryov (vponomaryov) |
status: | New → In Progress |
Changed in manila: | |
status: | Fix Committed → Fix Released |
Changed in manila: | |
milestone: | kilo-1 → 2015.1.0 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/108193 /git.openstack. org/cgit/ stackforge/ manila/ commit/ ?id=ab02ab46457 2062029eae49c1e 67eeb28305e8cf
Committed: https:/
Submitter: Jenkins
Branch: master
commit ab02ab464572062 029eae49c1e67ee b28305e8cf
Author: Valeriy Ponomaryov <email address hidden>
Date: Sat Jul 19 12:06:09 2014 +0300
Fix service subnet capacity within service_instance module
Module 'service_instance' creates service_subnet per neutron_subnet,
current mask is 29, that allows take only 3 (three) ips for service
instances. Changed mask to 28, that allows take 11 (eleven) ips now
by default.
It allows us to use multibackend installation with drivers, that
depend on this module more reliably and provides possibility to
change this value in general.
Changes:
- added config option for network subnets mask with default value 28,
instead of hardcoded 29.
- fixed related unittests
Change-Id: Ib58048832287a9 f184317d2c92f0c c22e7f2a303
Closes-Bug: #1341711
Related-Bug: #1330391