Heat can lose track of resources after a failed update

[Zane Bitter]

If a stack update removes a resource from the template, rollback is disabled and the update fails for any reason before the resource is fully deleted, then the resource will be orphaned and will not be deleted on a subsequent stack delete.

(Similarly, if the new template adds a resource, the update fails after the resource is created and then rollback fails before the resource is removed again, the same will occur.)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100046

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100046
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=22b23446fd4d3ce4ee096d961e95182877262c62
Submitter: Jenkins
Branch: master

commit 22b23446fd4d3ce4ee096d961e95182877262c62
Author: Zane Bitter <email address hidden>
Date: Mon Jun 16 11:05:18 2014 -0400

    Update template incrementally as resources change

    As a stack update progresses, maintain the contents of the template so that
    they represent the current running state of the stack, instead of only
    switching over wholesale at the end, so that if a failure occurs our state
    and the template stored will be consistent.

    Change-Id: If79e8b1dc212c548cad92fdbc340d61f5650f9d4
    Implements: partial-blueprint update-failure-recovery
    Closes-Bug: #1330016

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/103236

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/103236
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d278a8cda548e2249eb8a4683c40ac63234faf3a
Submitter: Jenkins
Branch: master

commit d278a8cda548e2249eb8a4683c40ac63234faf3a
Author: Zane Bitter <email address hidden>
Date: Tue Jul 8 09:43:01 2014 -0400

    Unit tests: Check for lost resource after failed rollback

    Check that when a new resource is added to a stack during an update and it
    is unable to be deleted during rollback, that we do not lose track of it
    but rather it remains in the template whence we can later attempt again to
    delete it.

    Change-Id: I83ebbc16c84561b69f9bdb8e7485de85b695c1b8
    Related-Bug: #1330016