Snapshot is deleted after instance is terminated

[Dennis Kliban]

NovaImageBuilder runs Anaconda and other installers inside a nova instance. After the install the instance is shut down and a snapshot is taken. After the snapshot finishes being saved the instance is terminated. In the last week I have noticed that the snapshot gets deleted also.

[Dennis Kliban (dkliban)]

My code checks that the snapshot becomes 'active' before terminating the instance. However, the compute node seems to think that it is still in a Saving state so it deletes the snapshot. This feature was added here: https://github.com/openstack/nova/commit/ad0940b724c34f3ed04fd8374e2843d522deb78c

However, I don't think it is working properly.

[Matt Riedemann (mriedem)]

What level of code is this against? Trunk/juno or stable/icehouse?

[Dennis Kliban (dkliban)]

I run this against trunk. We have a devstack environment that we install nightly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100120

[Dan Prince (dan-prince)]

This looks like a clear regression caused by https://review.openstack.org/#/c/82455/.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100120
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c28956a6872b34a93891c985c93aad5e242563b6
Submitter: Jenkins
Branch: master

commit c28956a6872b34a93891c985c93aad5e242563b6
Author: lvdongbing <email address hidden>
Date: Mon Jun 16 09:11:32 2014 +0800

    Should not delete active snapshot when instance is terminated

    The instance might be deleted when doing snapshot, need to check
    whether the snapshot is active state before delete it.

    Change-Id: Ic12b8dfd05ad7f36831dd073cef746f094d8f2d0
    Closes-Bug: #1329882