Catfish doesn't use locate command

[Denis Kovalev]

To reproduce (the simplest way, with no debug): edit /usr/share/catfish/catfish/CatfishSearchEngine.py and leave only 'locate' as search method:

class CatfishSearchEngine:
    """CatfishSearchEngine is the collection of search backends that are used
    to perform a query. Each backend is a CatfishSearchMethod"""

    def __init__(self, methods=['locate']):

then run the application and try to search for any existing file/directory (with default search options). Catfish will return 'No results' although the corresponding locate command does find the results.

The case is that python3 (and python2) subprocess module use a list as the input command, not string, that's why CatfishSearchMethodExternal.run() doesn't work as expected. You may use the attached patch for CatfishSearchEngine.py
(installed: /usr/share/catfish/catfish/CatfishSearchEngine.py)

sudo patch /usr/share/catfish/catfish/CatfishSearchEngine.py <attached patch file>

[Si Dedman (si-dedman)]

Looks like that's done the trick, cheers Denis, and extra cheers for explaining how to patch! :)

Will this be pushed into the next release for those subscribed to the PPA?

[Sean Davis (bluesabre)]

Thanks for the bug report and patch! I've rolled your fix into trunk.