test_uri_length_limit follows proxy and hits wrong localhost

Bug #1329614 reported by Angus Lees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Angus Lees

Bug Description

test_uri_length_limit honours HTTP_PROXY (if set). This means the test queries to http://localhost:$port/ hit the wrong localhost when $HTTP_PROXY is another host, resulting in a meaningless test scenario, and apparent failures with HTTP status codes other than REQUEST_URI_TOO_LARGE (414).

Tags: testing
Angus Lees (gus)
Changed in nova:
assignee: nobody → Angus Lees (gus)
Revision history for this message
Burt Holzman (holzman) wrote :

I've got a quick fix for this.

Revision history for this message
Burt Holzman (holzman) wrote :

Oh, nevermind. Looks lik your fix https://review.openstack.org/#/c/99823/ didn't get linked in to the bug.

Tracy Jones (tjones-i)
tags: added: testing
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/99823
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7e54641fc1f760423c2f1210787903e17ea1cc06
Submitter: Jenkins
Branch: master

commit 7e54641fc1f760423c2f1210787903e17ea1cc06
Author: Angus Lees <email address hidden>
Date: Fri Jun 13 12:20:54 2014 +1000

    Don't follow HTTP_PROXY when talking to localhost test server

    Unlike urllib2, requests honours HTTP_PROXY by default. This meant
    test_uri_length_limit's test queries to http://localhost:$port/ would
    hit the wrong localhost when $HTTP_PROXY was another host - resulting in a
    meaningless test scenario and apparent failures with HTTP status codes
    other than the expected REQUEST_URI_TOO_LARGE (414).

    This change forces requests to go direct for those test queries.

    Closes-Bug: #1329614
    Change-Id: Ida3424ca9a750bd2d3f2e81dc7dfacc2a334adf1

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.