graphics_driver failed to parse the latest nvidia 331.38 driver

[Po-Hsu Lin]

Found this issue on a HP desktop system (201301-12638)
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GF119M [GeForce 705M] [10de:105b] (rev a1)

Driver: nvidia-331 331.38-0ubuntu7

Unity support test shows:
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce 705A/PCIe/SSE2
OpenGL version string: 4.4.0 NVIDIA 331.38

Not software rendered: yes
Not blacklisted: yes
GLX fbconfig: yes
GLX texture from pixmap: yes
GL npot or rect textures: yes

Compiz supported: yes

But for our tool:
------------- VIDEO DRIVER INFORMATION -------------
ERROR: No video driver loaded! Possibly in failsafe mode!
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: Intel (8086:0152)
Graphics Chipset: NVIDIA (10de:105b)
Loaded DDX Drivers: modesetting
Hybrid Graphics: no

[Zygmunt Krynicki (zyga)]

Given that we have the Xorg.0.log attached I'm setting this to triaged

[Po-Hsu Lin (cypressyew)]

From the graphic_driver script, it tries to parse this pattern from the Xorg.0.log:
'\(II\) (.*)\(\d+\): Setting mode "(.*?):'

But from this system, the targeted line becomes:
[ 2955.776] (II) NVIDIA(0): Setting mode "NULL"

(reference output from another system running 12.04.4 + nvidia driver:
[ 2521.898] (II) NVIDIA(0): Setting mode "LVDS-0: nvidia-auto-select @1920x1080 +0+0 {ViewPortIn=1920x1080, ViewPortOut=1920x1080+0+0}")

The fix will be easy, we could just remove the ":"
But I'm not sure if this is a good idea.

[Daniel Manrique (roadmr)]

Just removing the ":" doesn't work, the second item in the matches tuple would be an empty string ('')
 (whereas in your example, we need LVDS-0 for the output).

I'll propose a solution using two regexes, it seemed to work well with your sample log file and should also work with the first example.