AltManager class is a landmine and should be removed

[David Kranz]

After the auth refactor, AltManager is the same as Manager except for the constructor arguments. In addition, it seems that it is only correct to call AltManager() if tenant isolation is disabled. A patch to fix a case where this was not done correctly has been submitted https://review.openstack.org/#/c/97139/7. This is not documented. It would be better to remove this class and replace it with a function that returns a Manager with alt credentials, doing the right thing whatever the value of allow_tenant_isolation.

[Ghanshyam Mann (ghanshyammann)]

As mentioned in bug, usage of AltManager has been fixed in https://review.openstack.org/#/c/107685/.

I will put a patch to remove the class also as it is unused now.

[Matt Riedemann (mriedem)]

It sounds like https://review.openstack.org/#/c/107685/ is also blowing up the nightly periodic test runs where allow_tenant_isolation=False.

[Matt Riedemann (mriedem)]

This should fix the bug with allow_tenant_isolation=False:

https://review.openstack.org/#/c/129291/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129291
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=e59f0fffb28a1b98476e3cc7dfaaed33f469711b
Submitter: Jenkins
Branch: master

commit e59f0fffb28a1b98476e3cc7dfaaed33f469711b
Author: Joseph Lanoux <email address hidden>
Date: Fri Oct 17 14:56:56 2014 +0000

    Add cleanup to test_verify_multiple_nics_order

    This test doesn't cleanup the networks and subnets that it created. Following
    Tempest tests in non-isolated environments are consequently failing because
    multiple networks are found. This change deleted those networks and subnets.

    Related-Bug: #1329065

    Change-Id: Id618aeeb85e3d4767ed07b4d29b908274eba76df

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/130415
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=8a938ad17d2cf51bae044c38b4099a396658febd
Submitter: Jenkins
Branch: master

commit 8a938ad17d2cf51bae044c38b4099a396658febd
Author: ghanshyam <email address hidden>
Date: Thu Oct 23 11:04:35 2014 +0900

    Remove AltManager class from client

    As Change-Id: I280f2b1659c593e14ab9213a161b55bcfc08fa5c has modified
    the Manager instantiation for non isolated tenant, AltManager class
    is no more needed.

    Tests runs for non isolated by instantiating the Manager with 'alt'
    credential.

    This patch removes the class AltManager from client.py

    Closes-Bug: #1329065

    Change-Id: I0dcf4050d8524655b017b4b5308fe3070aa2f840