Desatuate played part of track in decks and samplers

Bug #1328748 reported by naught101
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
-MK-

Bug Description

Sometimes it's quite hard to see the play marker in the deck, because it's just a thin green line - at least this is the case in the Deere and Latenight skins. It would be good to also grey out or darken the part of the track that has already been played, as a stronger visual aid.

naught101 (naught101)
tags: added: easy
Revision history for this message
Lee Matos (lbot) wrote :

This is something that should be accomplished by editing the skin. I'll look up the exact bit, but it shouldn't be hard.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

If you wish to dark the waveform, it is a waveform render issue.
It depends on the waveform renderer how hard it is.
We may overlay a gray transparent picture, but that draws CPU.

Alternatively we May change the appearance of the current position marker ...
or just change the background.

Revision history for this message
naught101 (naught101) wrote : Re: [Bug 1328748] Re: Desatuate played part of track in decks and samplers

It's not really important whether is it darkening or desaturation, or a grey overlay. What is important is the visual differentiation. Any of those will do it.

On 11 June 2014 6:26:43 PM AEST, "Daniel Schürmann" <email address hidden> wrote:
>If you wish to dark the waveform, it is a waveform render issue.
>It depends on the waveform renderer how hard it is.
>We may overlay a gray transparent picture, but that draws CPU.
>
>Alternatively we May change the appearance of the current position
>marker ...
>or just change the background.
>
>--
>You received this bug notification because you are subscribed to the
>bug
>report.
>https://bugs.launchpad.net/bugs/1328748
>
>Title:
> Desatuate played part of track in decks and samplers
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/mixxx/+bug/1328748/+subscriptions

--
Sent from my pocket robot.

Revision history for this message
David Robert Piper (drppublic-deactivatedaccount) wrote :

Maybe there could be a setting to automatically set the marker to the complementary colour of the waveform? (If the waveform is primarily blue, the marker is set to yellow, etc...)

I'd hop on this bug myself but I'm still finding my way around the project :-)

jus (jus)
tags: added: polish usability waveform
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
-MK- (mk42) wrote :

I would really like that for the overview waveform in the new Tango skin.

Any objections about implementing this?
I don't know if desaturating after the current playhead should be
A) be default for the overview-waveforms
B) be a config-option for the renderers or if we should
C) add another 'X-desaturating' renderer for X in (Filtered, RGB, HSV)

I would not implement that for scrolling waveforms, because it's probably more important to see the beats and stuff in that view, isn't it?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

It is probable most straight forward to start with C
If one day all waveforms have this feature, we can consider to move it from the name to a dedicated preference option (B) or just remove to old versions (A)

Revision history for this message
-MK- (mk42) wrote :

I had a look at the implementation of WOverview and found a really simple solution that would work for me.
see https://github.com/mixxxdj/mixxx/pull/1203

Revision history for this message
-MK- (mk42) wrote :

Sorry Daniel, I missed your comment. It didnt show up when I wrote my Last.

I found an easy solution by overlaying the overview with a skin configurable color. See my pull request for that.

I think Performance weise its best Like that. And skin artists can decide How it should Look in each skin.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Ah, so you wish to move the decision if the waveform should be desaturated or not to the skin?
That works for me. If we have users complaining about it, we can always introduce a new config option fro it B or C.

What does it mean for legacy skins? I think thy should not be desaturated by default.
So we should not fall back to semitransparent gray if "PlayedOverlayColor" is not set.

Revision history for this message
Be (be.ing) wrote :

> If we have users complaining about it, we can always introduce a new config option fro it B or C.

We should not introduce yet another preference option for this. IMO this is quite unambiguously a good idea. If a user really does not like it they can edit the skin.

jus (jus)
Changed in mixxx:
assignee: nobody → -MK- (mk42)
status: Confirmed → Fix Committed
tags: added: skin
Changed in mixxx:
milestone: none → 2.1.0
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7504

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.