fc_zone_manager.py not parsing list value consistently for fc_fabric_names

[Michael Denny]

fc_zone_manager.py not parsing list value consistently for fc_fabric_names

adding value to fc_fabric_names requires a space after the ,

[fc-zone-manager]
brcd_sb_connector=cinder.zonemanager.drivers.brocade.brcd_fc_zone_client_cli.BrcdFCZoneClientCLI
fc_fabric_names=BRCD_FAB_1, BRCD_FAB_2
zone_name_prefix=cld1
fc_san_lookup_service=cinder.zonemanager.drivers.brocade.brcd_fc_san_lookup_service.BrcdFCSanLookupService
zone_driver=cinder.zonemanager.drivers.brocade.brcd_fc_zone_driver.BrcdFCZoneDriver
zoning_policy=initiator-target

[Michael Denny (michael-denny)]

stack trace

2014-06-10 09:29:54.107 ERROR cinder.utils [req-c7fb120b-c6b5-423f-81ee-812b6e156913 30c03b7fe9104573acad6caceb798d09 f713a24644b24686ba7d2976cba0712c] Error connecting v
ia ssh: Specify a password or private_key
2014-06-10 09:29:54.107 ERROR cinder.zonemanager.drivers.brocade.brcd_fc_zone_driver [req-c7fb120b-c6b5-423f-81ee-812b6e156913 30c03b7fe9104573acad6caceb798d09 f713a24644
b24686ba7d2976cba0712c] Error connecting via ssh: Specify a password or private_key
2014-06-10 09:29:54.108 ERROR cinder.zonemanager.fc_zone_manager [req-c7fb120b-c6b5-423f-81ee-812b6e156913 30c03b7fe9104573acad6caceb798d09 f713a24644b24686ba7d2976cba071
2c] Failed adding connection for fabric=None: Error:Failed to get SAN context Error connecting via ssh: Specify a password or private_key
2014-06-10 09:29:54.108 ERROR cinder.volume.manager [req-c7fb120b-c6b5-423f-81ee-812b6e156913 30c03b7fe9104573acad6caceb798d09 f713a24644b24686ba7d2976cba0712c] Fibre Cha
nnel connection control failure: Failed adding connection for fabric=None: Error:Failed to get SAN context Error connecting via ssh: Specify a password or private_key
2014-06-10 09:29:54.108 ERROR oslo.messaging.rpc.dispatcher [req-c7fb120b-c6b5-423f-81ee-812b6e156913 30c03b7fe9104573acad6caceb798d09 f713a24644b24686ba7d2976cba0712c] E
xception during message handling: Fibre Channel connection control failure: Failed adding connection for fabric=None: Error:Failed to get SAN context Error connecting via
 ssh: Specify a password or private_key
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher Traceback (most recent call last):
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 134, in _dispatch_and_r
eply
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher incoming.message))
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 177, in _dispatch
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 123, in _do_dispatch
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher result = getattr(endpoint, method)(ctxt, **new_args)
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 837, in initialize_connection
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher self._add_or_delete_fc_connection(conn_info, 1)
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 1335, in _add_or_delete_fc_connection
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher LOG.error(e)ye
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/openstack/common/excutils.py", line 68, in __exit__
2014-06-10 09:29:54.108 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
2014-06-10 09:29:5...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/99201

[Michael Denny (michael-denny)]

Workaround until review lands.
fc_fabric_names=BRCD_FAB_1,BRCD_FAB_2

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/99201
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=280cb0314958bb7d8e58954a17bbef675d76e3fc
Submitter: Jenkins
Branch: master

commit 280cb0314958bb7d8e58954a17bbef675d76e3fc
Author: Walter A. Boring IV <email address hidden>
Date: Tue Jun 10 13:40:36 2014 -0700

    Fix Brocade FC driver's use of the fc_fabric_names

    The Brocade Fibre Channel Zone Manager driver wasn't
    stripping out whitespace in the fc_fabric_names
    prior to using them. This would cause breakage later on
    in the driver.

    Change-Id: I6d16a35026fdd2f30a92f9dff16435a6c39b699a
    Closes-Bug: 1328681