Ubuntu servers trying to restore selinux context when facter returns false

Bug #1328547 reported by David Moreau Simard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Undecided
David Moreau Simard
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

# facter -p |grep selinux
selinux => false

Yet the manifest attempts to restore the selinux context:
Swift::Storage::Xfs[sdf]/Swift::Storage::Mount[sdf]/Exec[restorecon_mount_sdf]: Could not find command 'restorecon'

Relevant commit:
https://review.openstack.org/#/c/94172/

Changed in puppet-swift:
assignee: nobody → François Charlier (francois-charlier)
status: New → Confirmed
assignee: François Charlier (francois-charlier) → nobody
Changed in puppet-swift:
assignee: nobody → David Moreau Simard (dmsimard)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/99107

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99112

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/99107
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=6d35b1e8cf41a4c86b9aec7f9d7b5bced93cba7e
Submitter: Jenkins
Branch: master

commit 6d35b1e8cf41a4c86b9aec7f9d7b5bced93cba7e
Author: David Moreau Simard <email address hidden>
Date: Tue Jun 10 10:52:18 2014 -0400

    Fix boolean that always returned true for selinux fact

    Facter returns 'false' if selinux is not enabled.
    Puppet evaluates it as true as it is not empty.

    Change-Id: I2f1d9a348fd981292aeef177b57f08e1b7ef2732
    Closes-bug: #1328547

Changed in puppet-swift:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/icehouse)

Reviewed: https://review.openstack.org/99112
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=8ccbb688ea2e06639e21fdc4b033315b7165c515
Submitter: Jenkins
Branch: stable/icehouse

commit 8ccbb688ea2e06639e21fdc4b033315b7165c515
Author: David Moreau Simard <email address hidden>
Date: Tue Jun 10 10:52:18 2014 -0400

    Fix boolean that always returned true for selinux fact

    Facter returns 'false' if selinux is not enabled.
    Puppet evaluates it as true as it is not empty.

    Change-Id: I2f1d9a348fd981292aeef177b57f08e1b7ef2732
    Closes-bug: #1328547
    (cherry picked from commit 6d35b1e8cf41a4c86b9aec7f9d7b5bced93cba7e)

tags: added: in-stable-icehouse
Mathieu Gagné (mgagne)
Changed in puppet-swift:
milestone: none → 5.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.