some exceptions not thrown correctly in neutron_plugin_db.py

[Vedamurthy Joshi]

If i try to delete a non-existing fip, it causes the below exception.

root@nodec22:/var/log/contrail# neutron floatingip-delete test2
Request Failed: internal server error while processing your request.
root@nodec22:/var/log/contrail#

The above is a description of an error in a Python program. Here is
the original traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_interface.py", line 431, in plugin_get_floatingip
    fip_info = cfgdb.floatingip_read(floatingip['id'])
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_db.py", line 2738, in floatingip_read
    raise l3.FloatingIPNotFound(floatingip_id=fip_uuid)
NameError: global name 'l3' is not defined

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/bottle.py", line 764, in _handle
    return route.call(**args)
  File "/usr/lib/python2.7/dist-packages/bottle.py", line 1575, in wrapper
    rv = callback(*a, **ka)
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_interface.py", line 518, in plugin_http_post_floatingip
    return self.plugin_get_floatingip(context, floatingip)
  File "/usr/lib/python2.7/dist-packages/vnc_openstack/neutron_plugin_interface.py", line 435, in plugin_get_floatingip
    raise e
NameError: global name 'l3' is not defined
10.204.217.108 - - [2014-06-10 16:49:17] "POST /neutron/floatingip HTTP/1.1" 500 156 0.018937

[Sachin Bansal (sbansal)]

Problem doesn't exist in 1.06. Only exists in 1.1

[Sachin Bansal (sbansal)]

https://github.com/Juniper/contrail-controller/commit/131db629514733eaab34129b2771f808df0b5713