Remove redundant heat templates from codebase

Bug #1328464 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Denis M.

Bug Description

Since https://github.com/openstack/trove/commit/22a88859e472a870595751029b610e250357dd63 was merged (Use tcp/udp ports from config for heat templates) we can clean up codebase from redundant heat templates because now codebase templates are equal, the only difference is in template description ("Heat template for {datastore}").

It would be nice to have only one template in codebase that can work with each datastore inside Trove-integration. And if deployer wants to use custom template - he's already able to do that.

Take a look at current templates (https://github.com/openstack/trove/tree/master/trove/templates), they already parametrized as possible. And this is a good reason to remove other templates.

Common template would be moved to /templates/default.heat.template

Denis M. (dmakogon)
Changed in trove:
assignee: nobody → Denis M. (dmakogon)
status: New → In Progress
summary: - Remove redundant heat templates from Trove codebase
+ Remove redundant heat templates from codebase
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/99000

Changed in trove:
importance: Undecided → Medium
importance: Medium → Low
milestone: none → ongoing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/99000
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=4019d030f99f88169df9fa614faf40a552703b2d
Submitter: Jenkins
Branch: master

commit 4019d030f99f88169df9fa614faf40a552703b2d
Author: Denis Makogon <email address hidden>
Date: Tue Jun 10 13:15:35 2014 +0300

    Remove redundant heat templates from codebase

    Reasons:
     - Heat templates are not unique anymore:
       - last thing was - dependency on tcp/udp ports from configuration.

    Changes:
     - use default.heat.template for each datastore;
     - removed all {datastore}/heat.templates;

    Behaviour:
     - deployer still can use custom templates for each of datastores;

    Change-Id: Ifc8b23e4158fd20c7fc3ed8701660747962d5506
    Closes-Bug: #1328464

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: ongoing → juno-2
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.