Fuel CI fails with no licence data found error

Bug #1328427 reported by Igor Shishkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Igor Shishkin

Bug Description

Cleaning up...
+ flake8 --version
2.0 (pep8: 1.4.5, pyflakes: 0.7.2, GitCheckCommitTitleBug: 0.0.1, GitCheckCommitTitleLength: 0.0.1, GitCheckCommitTitlePeriodEnding: 0.0.1, hacking.core: 0.0.1, ProxyChecker: 0.0.1, mccabe: 0.2.1)
+ '[' -x ./run_tests.sh ']'
+ ./run_tests.sh --with-xunit
Starting Flake8 tests...
4
./nailgun/nailgun/db/migration/alembic_migrations/env.py:1:1: H102 Apache 2.0 license header not found
from __future__ import with_statement
^
Check for Apache 2.0 license.

    H102 license header not found
./nailgun/nailgun/db/migration/alembic_migrations/versions/fuel_5_0.py:1:1: H102 Apache 2.0 license header not found
"""fuel_5_0
^
Check for Apache 2.0 license.

    H102 license header not found
./nailgun/nailgun/db/migration/alembic_migrations/versions/fuel_5_0_1.py:1:1: H102 Apache 2.0 license header not found
"""fuel_5_0_1
^
Check for Apache 2.0 license.

    H102 license header not found
./fuelmenu/fuelmenu/common/timeout.py:1:1: H102 Apache 2.0 license header not found
import thread
^
Check for Apache 2.0 license.

    H102 license header not found
Starting Nailgun tests...

https://fuel-jenkins.mirantis.com/job/stackforge-verify-fuel-web/3760/consoleFull

Changed in fuel:
milestone: 4.1.1 → 5.0.1
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Artem Roma (aroma-x)
status: Confirmed → In Progress
Revision history for this message
Artem Roma (aroma-x) wrote :

Fix for this bug is introduced in https://review.openstack.org/#/c/97915/

Changed in fuel:
assignee: Artem Roma (aroma-x) → Igor Shishkin (teran)
Revision history for this message
Mike Scherbakov (mihgen) wrote :

Why it doesn't fail in all other patches? Only in https://review.openstack.org/#/c/97915/ ?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/97915
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=48f0b07b26971b77021506769d71a083ebb0f7f8
Submitter: Jenkins
Branch: master

commit 48f0b07b26971b77021506769d71a083ebb0f7f8
Author: Igor Shishkin <email address hidden>
Date: Thu Jun 5 00:34:03 2014 +0400

    LICENCE added

    Change-Id: I48f1e27dbc3db1ec10f5f611db835084e98db483
    Partial-Bug: #1326514
    Closes-Bug: #1328427

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Dmitry Borodaenko (angdraug) wrote :

The fix is incorrect: it added copyright information to autogenerated alembic migrations instead of excluding them from the test. Please fix. Milestone was also set incorrectly: this doesn't seem to affect stable/5.0, so target milestone should be 5.1.

Changed in fuel:
status: Fix Committed → Confirmed
status: Confirmed → Triaged
milestone: 5.0.1 → 5.1
Revision history for this message
Dima Shulyak (dshulyak) wrote :

Dmitry, copyright for migrations done exactly the same way it is done in openstack projects, see neutron for example:
https://github.com/openstack/neutron/blob/master/neutron/db/migration/alembic_migrations/script.py.mako

Revision history for this message
Igor Shishkin (teran) wrote :

Currently it's fixed. We have Licence info in all repos, flake8 licence test passes fine on master code.

Changed in fuel:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.