LVM driver: unable to create a share

[Alex Meade]

When attempting to create a Share without a snapshot ref using the lvm driver, the following traceback occurs and the share goes into ERROR status.

2014-06-09 11:54:57 ERROR [manila.openstack.common.rpc.amqp] Exception during message handling
Traceback (most recent call last):
  File "/opt/stack/manila/manila/openstack/common/rpc/amqp.py", line 433, in _process_data
    **args)
  File "/opt/stack/manila/manila/openstack/common/rpc/dispatcher.py", line 148, in dispatch
    return getattr(proxyobj, method)(ctxt, **kwargs)
  File "/opt/stack/manila/manila/share/manager.py", line 165, in create_share
    self.db.share_update(context, share_id, {'status': 'error'})
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/opt/stack/manila/manila/share/manager.py", line 159, in create_share
    context, share_ref, share_server=share_server)
TypeError: create_share() got an unexpected keyword argument 'share_server'

This is because the manila/share/manager.py is calling:
158 export_location = self.driver.create_share(
159 context, share_ref, share_server=share_server)

but the lvm drivers create_share method does not have the kwarg 'share_server'

[Valeriy Ponomaryov (vponomaryov)]

see: https://review.openstack.org/#/c/98107/