resource-template shows wrong type for Boolean

Bug #1328022 reported by Zhang Yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Zhang Yang

Bug Description

resource-template shows wrong type if the property is Boolean, it returns "String"

/opt/stack$heat resource-template OS::Ceilometer::Alarm

 enabled:
    AllowedValues: ['True', 'true', 'False', 'false']
    Default: 'true'
    Description: True if alarm evaluation/actioning is enabled.
    Type: String

String can't be used as Boolean after boolean-parameter-type was merged.

https://github.com/openstack/heat/commit/6984a7793883164af0e28c3e707048e989670e9d

Changed in heat:
assignee: nobody → Zhang Yang (neil-zhangyang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98726

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/98726
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d94958be1717acd696211ba5b08a04718325dfd4
Submitter: Jenkins
Branch: master

commit d94958be1717acd696211ba5b08a04718325dfd4
Author: Zhang Yang <email address hidden>
Date: Mon Jun 9 03:01:08 2014 -0700

    Fix property-parameter mapping for boolean property

    resource-template returns wrong parameter type "string" for
    boolean property, which is wrong after boolean-parameter-type
    (commit:6984a7793883164af0e28c3e707048e989670e9d) was merged.
    boolean property should be mapped to parameters.Schema.BOOLEAN

    Change-Id: I9841545a8e740ecf5ba1806e807bbe15feede69f
    Closes-Bug: #1328022

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.