Allow to set <Variable name="???"/> from color scheme

[Daniel Schürmann]

This could be useful to replace images or tweak for mixing styles.

This is a follow up from https://bugs.launchpad.net/mixxx/+bug/1327614

[jus (jus)]

So color scheme support has a future?
I understood support for color schemes slowly fade out.

[Daniel Schürmann (daschuer)]

I like it: The new Shade skin has some, to implement a dark and light version.
But there is room for improvements.

[jus (jus)]

Yeah, i noticed you like it :)

Just to make it clear for anyone interested in picking up this bug.
What exactly would you use this <Variable name="???"/> feature for, in connection with color schemes.
Would this allow to make something like lp:1256351

[RJ Skerry-Ryan (rryan)]

I like the idea of color schemes too but I think we should phase out the bitmap-transformation aspect of them (since we are moving to vector images) and maybe focus on using SVG-variables as added in:
https://github.com/mixxxdj/mixxx/pull/302
to implement them.

It would also be so easy to support conditional CSS based on the selected scheme.

[Be (be.ing)]

There has been no progress on this lately, so I am removing the 2.1.0 milestone.

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/1988

[Hendrik (index82)]

The PR #1988 has no function in Release 2.2.3.
I tested it with Shade and extended the scheme.

...
<Scheme>
<Name>Classic</Name>
   <Filters/>
   <SetVariable name="BgColor">#5EBAFF</SetVariable>
  </Scheme>

The variable is not passed. Or I did something wrong.

BTW: Is there a way to view all keys and variables via CLI or Developertools?

[Hendrik (index82)]

oops, I wasn't finished.

skins/Shade/skin.xml

<Schemes>
  <Scheme>
    <Name>Classic</Name>
     <Filters/>
     <SetVariable name="BgColor">#5EBAFF</SetVariable>
  </Scheme>
  ...
</Schemes>

skins/Shade/deck.xml

<Visual>
  ...
  <BgColor><Variable name="BgColor"/></BgColor>
  ...
</Visual>

[ronso0 (ronso0)]

That PR was merged to master so the status is Fix Committed.
As soon as it's in a official release (2.3) it's changed to Fix Released.

You can grab master builds from http://downloads.mixxx.org/builds/master/release/

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7502