Verification values are hard coded in /tempest/api/orchestration/

Bug #1327919 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Undecided
Ghanshyam Mann

Bug Description

In tests under /tempest/api/orchestration/, resources gets created based on parameters defined in template (yaml, json). But while verification of output, expected values are hard coded in tests. Expected values should be read from template only.

If we change the template value, resources get created successfully but tests fail due to hard coded expected values in tests. To make tests pass, we need to change the tests expected values also along with template values.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tempest (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/98676

Changed in tempest:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102755

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/98676
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=961ea1adb882a187fbc2878a092974253481becb
Submitter: Jenkins
Branch: master

commit 961ea1adb882a187fbc2878a092974253481becb
Author: Ghanshyam <email address hidden>
Date: Mon Jun 9 10:56:00 2014 +0900

    Read template's expected value orchest test Part-1

    In tests under /tempest/api/orchestration/, resources gets
    created based on parameters defined in template (yaml, json).
    But while verification of output, expected values are hard coded
    in tests. Expected values should be read from template only.

    This patch adds the helper to load the values from template
    (yaml, json) and apply the changes in
    tempest/api/orchestration/test_volumes.py

    This patch also rename the existing load_template() function
    as it read the template and newly added function load the template
    This rename the load_template() to read_template in
    tempest/api/orchestration/base.py and corresponding calling files.

    Partial-Bug: #1327919

    Change-Id: Ie0817e20cb7bacdf33b16fb222a7ee9c91109fc8

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/102755
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=f36b0d462c15958b8234aa1928714e51995b385b
Submitter: Jenkins
Branch: master

commit f36b0d462c15958b8234aa1928714e51995b385b
Author: Ghanshyam <email address hidden>
Date: Thu Jul 10 10:24:29 2014 +0900

    Read template's expected value orchest test Part-2

    In tests under /tempest/api/orchestration/, resources gets
    created based on parameters defined in template (yaml, json).
    But while verification of output, expected values are hard coded
    in tests.
    Expected values should be read from template only.
    This patch covers the following files -
        test_environment.py
        test_nova_keypair_resources.py
        test_swift_resources.py

    Closes-Bug: #1327919

    Change-Id: Ie241b7f299487cd0db384778225823e96fecf440

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.