Asymmetry in "sync" phase adjustment

Bug #1327640 reported by Jan-Philip Gehrcke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Owen Williams

Bug Description

Using 1.12 master from May 2014.

I have had a situation where syncing from left to right yielded the correct phase adjustment, whereas syncing from right to left produced a minor phase offset.

I could do that reproducibly, i.e. when I pressed the left sync button the two tracks were synced perfectly, but when I then pressed the right sync button, the two tracks were *slightly* phase-shifted. When I then pressed the left sync button again, they were perfectly aligned again, and so on... back and forth.

I have had this before but did not investigate properly. This time, I tried to reproduce it with the same two tracks over and over again, and could reproduce. However, after Mixxx restart *I could not reproduce using the same two tracks*. Looks like some of my actions in the course of a Mixxx session brought Mixxx into this "malicious" state. I have no idea what that could have been unfortunately.

This asymmetry contradicts my understanding of how the underlying implementation should work -- in my naive view, this operation should be entirely symmetric, i.e. we have two markers and phase adjustment should align them. The difference between left -> right and right -> left should only be which of both tracks makes the "jump", but the alignment should eventually be marker-on-marker in both cases, right?

Some might ask: if left->right works, but right->left does not, why don't you just use left->right? When we have a silenced track and one that is currently playing on master, then obviously, we do not want the master one to make the jump, so the sync direction is predefined.

The music I was doing this with is electronic music, about 120 bpm. The beatgrid was set perfectly.

Revision history for this message
Owen Williams (ywwg) wrote :

Are you using master sync? Is quantize on? What about keylock?

Revision history for this message
Jan-Philip Gehrcke (jgehrcke) wrote :

I am not exactly sure regarding "master sync" but I understand that this is a new feature only available in special themes. I am using Deere and I have used the "sync" button. Hence, I guess I did not use master sync.

I have observed this with quantize and keylock both activated.

Revision history for this message
Owen Williams (ywwg) wrote :

It could be that when you sync with the right deck, it's using an out-of-date position to sync against. The right deck seeks, and the left deck is already one buffer ahead.

You should do testing with the Latenight-Stacked skin, which has all the new features. Master sync is engaged by clicking and holding the sync button. But anyway, one-shot sync should work so I'll take a look at this.

Revision history for this message
Jan-Philip Gehrcke (jgehrcke) wrote :

FWIW, I have observed this behavior also with Latenight-Stacked, without using master sync. Again, I somehow got there, and a program restart made the problem disappear (for a while).

Revision history for this message
Jan-Philip Gehrcke (jgehrcke) wrote :

Sorry to bother you with that, but currently this for me is the most annoying issue when using Mixxx 1.12 in production. I still cannot reliably reproduce, but this happens over and over and really bring you into trouble when you are trying to precisely mix. Is someone investigating?

Revision history for this message
Owen Williams (ywwg) wrote :

I'll take a look

Changed in mixxx:
milestone: none → 1.12.0
assignee: nobody → Owen Williams (ywwg)
Revision history for this message
Owen Williams (ywwg) wrote :
Changed in mixxx:
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Owen Williams (ywwg) wrote :

This was fixed

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7500

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.