be able to hide/disable action menu item if not relevant

[Cindy Lu]

I am not sure how dynamic the action menu is, but...

For Project > Volumes table if I have a volume that is not bootable, the "Launch as Instance" action should be hidden/disabled so it doesn't confuse the user when they do attempt to launch it.

[Julie Pichon (jpichon)]

There's a "bootable" attribute on Volumes that we could probably use in the allowed() function for the LaunchAction.

https://github.com/openstack/horizon/blob/a04d81e026/openstack_dashboard/dashboards/project/volumes/volumes/tables.py#L36
https://github.com/openstack/horizon/blob/a04d81e0262f56c805b3de51bc69a1af2db0178b/openstack_dashboard/api/cinder.py#L79

[Ashish Chandra (ashish-chandra)]

I totally agree with Cindy, apart from this we can also add one more column in volumes tables, specfiying whether the said volume is bootable or not.

[Ashish Chandra (ashish-chandra)]

Ahhh... I was not running current master, so could not notice that we already have a bootable column in volumes table.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104343

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104343
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2bee960509f08877e6bfd317e5a4c142b828ae49
Submitter: Jenkins
Branch: master

commit 2bee960509f08877e6bfd317e5a4c142b828ae49
Author: Ashish Chandra <email address hidden>
Date: Thu Jul 3 02:39:50 2014 +0530

    Hiding "Launch as Instance" if volume is not bootable.

    If a volume which is not bootable, is used to create an instance
    then the instance will go into 'Error' state.
    The patch solves this issue by hiding the 'Launch as Instance'
    button if the volume is not bootable.

    Closes-Bug: #1327310

    Change-Id: I3d9e7edf846fafab4e735d562c1ec72ad32fb220

[Matthias Runge (mrunge)]

Did you ran tests and look at the output?

  File "/home/mrunge/work/horizon/openstack_dashboard/dashboards/project/volumes/volumes/tables.py", line 53, in allowed
    if volume and volume.bootable == 'true':
  File "/home/mrunge/work/horizon/openstack_dashboard/api/base.py", line 81, in __getattribute__
    return object.__getattribute__(self, attr)
AttributeError: 'VolumeSnapshot' object has no attribute 'bootable'