Fuel for OpenStack

fuel_upgrade: openstack engine incorretly checks releases for uniqueness

Bug #1327198 reported by Ihor Kalnytskyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Ihor Kalnytskyi
Fuel for OpenStack 5.1

Bug Description

OpenStack upgrader engine incorrectly checks for release uniquness. The issue is in next line:

    https://github.com/stackforge/fuel-web/blob/2853129b991f0c2ecbd60005ff0cdbfb830c0b6c/fuel_upgrade_system/fuel_upgrade/fuel_upgrade/engines/openstack.py#L68

We need to check not only name, but version too. It's a Nailgun's constraint.

Tags: fuelupgrade
Ihor Kalnytskyi (ikalnytskyi)
Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
milestone: none → 5.0.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100528

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Igor Kalnitsky (ikalnitsky)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/100528
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=d0e04d013bae035c1423bff36409138de9a68633
Submitter: Jenkins
Branch: master

commit d0e04d013bae035c1423bff36409138de9a68633
Author: Igor Kalnitsky <email address hidden>
Date: Fri Jun 13 15:19:30 2014 +0300

    OpenStack Patching: install repos/puppets

    The fuel-upgrade script have to install new repos and puppet scripts
    that will be used for openstack patching.

    Implements blueprint upgrade-to-5-1
    Closes-Bug: #1327198

    Change-Id: I8f3f0ba2dc30670c4cade52411690357d0afb675

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Evgeniy L (rustyrobot) wrote :

Was merged in master (5.1), not in stable/5.0.1, will be backported as a part of upgrade-to-5-0-1 blueprint.

Changed in fuel:
milestone: 5.0.1 → 5.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.