rescue_instance RPC has reverted to passing a dict

Bug #1327145 reported by Phil Day
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Phil Day

Bug Description

Change https://review.openstack.org/#/c/62314/ mistakenly made the conversion of the instance object in compute/rpcapi.py rescue_image() unconditional on the RPC version. From 3.9 onwards this should be passed as an object

Phil Day (philip-day)
Changed in nova:
importance: Undecided → Medium
assignee: nobody → Phil Day (philip-day)
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98470

Changed in nova:
status: New → In Progress
Revision history for this message
John Garbutt (johngarbutt) wrote :

We use milestones only at the very end of the milestone to track bugs that should block the release of the milestone. Please use tags not milestones to track bugs, try things like: my_bug_topic_milestone_name

tags: added: unified-objects
Changed in nova:
milestone: juno-2 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/98470
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c2aa27d6f86d9ead2a9653b07de425669351d93d
Submitter: Jenkins
Branch: master

commit c2aa27d6f86d9ead2a9653b07de425669351d93d
Author: Phil Day <email address hidden>
Date: Fri Jun 6 17:02:09 2014 +0000

    Fix error in rescue rpcapi that prevents sending objects

    The change restores the rescue_instance rpc's ability to send
    instance objects from version 3.11 onwards, that was inadvertently
    broken by https://review.openstack.org/#/c/62314

    Unit test modified to check that rpc version passes instance object
    instead of dict.

    Change-Id: Icffea82da623d3aab4661554b33bd5959bfe2bd8
    Closes-Bug: #1327145

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.