DockbarX >= rev 521 doesn't work with xfce4-dockbarx-plugin

[Ted Alff]

revision 521: self.container -> self.groups.box

When I change *.container to *.groups.box in src/xfce4-dockbarx-plug.py and recompile, I get this error when relaunching xfce4-panel:

  File "/usr/lib/python2.7/site-packages/dockbarx/dockbar.py", line 403, in on_size_allocate
    self.calculate_button_size()
  File "/usr/lib/python2.7/site-packages/dockbarx/dockbar.py", line 364, in calculate_button_size
    button_size = int(size * self.aspect_ratio + spacing)
TypeError: unsupported operand type(s) for *: 'int' and 'NoneType'

I tried changing self.aspect_ratio to 1 in/usr/lib/python2.7/site-packages/dockbarx/dockbar.py , and when I relaunched xfce4-panel, no error was reported, but dockbarx didn't load.

dockx (standalone dock) launches without issue.

Reported to xfce4-dockbarx-plugin at github too.

Arch Linux x86_64, dockbarx-bzr rev 525, xfce4-dockbarx-plugin 0.2.1 (with change noted above)

[Matias Särs (msevens)]

Thanks for reporting. It's great that someone is testing the new code with the xfce plugin!

Try changing line 119 in xfce4-dockbarx-plug.py from
self.dockbar.orient = orient
to
self.dockbar.set_orient(orient)

That should fix it, if I'm not mistaken. If it works, could you make a pull request with your changes to github? Tiz said he isn't actively developing the plugin anymore but he gladly merges pull requests.

[Matias Särs (msevens)]

Oh, and line 120 - 122

      if orient in ("left", "right"):
            self.dockbar.container.destroy()
            self.dockbar.container = gtk.VBox()

should be removed completely, that should be handled by the set_orient function.

[N. W. (nw9165-3201)]

Hello,

here is the xfce4-dockbarx-plugin github thread regarding this issue:

https://github.com/TiZ-EX1/xfce4-dockbarx-plugin/issues/2

And please also have a look at this:

https://bugs.launchpad.net/dockbar/+bug/1329244
https://bugs.launchpad.net/dockbar/+bug/1329241
https://bugs.launchpad.net/dockbar/+bug/1329240
https://bugs.launchpad.net/dockbar/+bug/1316501

Regards

[Trent McPheron (tiz-ex1)]

N.W.: It is not appropriate to go plugging issues in other issues; it's about as tactful as a forum reply comprised only of the word "bump". When an issue is filed in an issue tracker, trust me, the maintainer is aware of them.

I'd like to keep master working with stable releases of DBX, but I'll create a branch intended to work with the development version and make these changes to the plug.