PageStack.push() eats header action popover close

Bug #1326963 reported by Nicholas Skaggs
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Critical
Tim Peeters
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned

Bug Description

Simply put, if you push a new page as part of an ontriggered event for a toolbar button, and that button is part of a popover, the next event on the pushed page is eaten by the popover which fails to close.

A simple example can be seen here:

lp:~nskaggs/+junk/pagestack-push

Run the included example.qml file and click the toobar button entitled 'Click Me!'. Notice the first click event to the textfield doesn't transfer focus as it should.

Including Tim's running commentary while investigating for more info :-)

<t1mp> the popover that shows the two actions doesn't close properly after the new page is pushed
<t1mp> so that is eating the events.
<t1mp> if I remove the pageStack.push from the action, it does close the popover
<t1mp> it seems it all works fine, except if in onTriggered, there is a pageStack.push().. then the Popover.close() that is called in onTriggered for the listitem (which represents the action) is not executed
<t1mp> when pushing a new page, the list of actions in the header changes, which destroys the list items in the popover that shows the actions
<t1mp> ^ and that happens before the onTriggered of the list item which should close the popover is executed
<t1mp> that messes up things

Related branches

description: updated
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
assignee: nobody → Tim Peeters (tpeeters)
status: New → Confirmed
importance: Undecided → Critical
Tim Peeters (tpeeters)
summary: - New header toolbar popover eats events
+ PageStack.push() eats header action overflow event
summary: - PageStack.push() eats header action overflow event
+ PageStack.push() eats header action popover close
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Incomplete
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.