VPNaaS enhance abstract methods for service driver APIs

[Paul Michali]

Currently an ABC is defined (VpnDriver) for the service driver APIs. For some of the methods that must be implemented by the vendor and reference service drivers, there is an abstract method defined in this class to ensure that the child classes implement the method:

    @abc.abstractmethod
    def create_vpnservice(self, context, vpnservice):
        pass

    @abc.abstractmethod
    def update_vpnservice(
        self, context, old_vpnservice, vpnservice):
        pass

    @abc.abstractmethod
    def delete_vpnservice(self, context, vpnservice):
        pass

However, for other methods, there are no abstract methods defined in VpnDriver. Fortunately, the reference implementation and every provider currently implement these methods in their child classes, but it would be good to enforce this in the ABC, so that any new service drivers will be sure to implement.

This is a low-hanging fruit enhancement, ideal for new contributors.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109087

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109087
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=940d125922f16ae8c2aa4187b46304fc66648c52
Submitter: Jenkins
Branch: master

commit 940d125922f16ae8c2aa4187b46304fc66648c52
Author: Ly Loi <email address hidden>
Date: Tue Jul 22 14:22:12 2014 -0700

    Define some abstract methods in VpnDriver class

    Define the <op>_ipsec_site_connection() methods to ensure any new
    service drivers will implement them.

    Closes-Bug: 1326793

    Change-Id: Idfe67632893592859990db486393a7108362447e