As part of bug 1291032 to fix PEP8 H302 violations, some changes made to UT files in Cisco VPNaaS were not correctly modified (imports that were for modules already, were changed to import the directory above, instead of being left alone).
The mistake wasn't detected, because the UT is currently deactivated. To verify the fix these things are needed:
1) Symlink tests/unit/services/vpn/device_drivers/notest_cisco_csr_rest.py to a name w/o no prefix.
2) manually include httmock library or the source file.
3) Run tox to verify the fix.
Problem affects notest_cisco_csr_rest.py and cisco_csr_mock.py in that area.
Long term the goal is to resolve the issue with this UTs library usage, but in the interim, we'd like to keep the file operational until that time (even if tested manually).
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7f0a8f09ab78671
Author: Paul Michali <email address hidden>
Date: Mon Jun 30 18:31:42 2014 -0400
VPNaaS REST Client UT Broken
When the H302 work was done, it broke two modules used for UT of
Cisco CSR VPNaaS REST client. Since the UT is currently disabled
(because the httmock library was not approved for test-requirements),
the error was not detected.
This fixes the files, so that they can still be used manually (by
locally importing httmock or its source file, and renaming the
module to remove the "_" prefix).
In the long term, the UT needs to be reworked to use httpretty,
which uses a register based mechanism, instead of a context
manager based mechanism, so this will take some effort. In addition.
there is discussion of switching to a new mock-request package,
instead of httpretty.
Change-Id: I8badc249ad021f
Closes-Bug: 1335977
Closes-Bug: 1326785