[astute] If puppet fails with dependency graph, fuel can't determine it

[Andrey Grebennikov]

If I change manifests and make a mistake, or in any other case if the deployment failed on the node with multiple roles assigned, puppet returns 0 as an exit code. Consequently Fuel continue deployment specifying the next assigned role to the node.
Seems something has been fixed in puppet.

[Andrew Woodward (xarses)]

This usually happens when puppet is evaluating the dependency graph and dies due for some reason, In this case puppet will return 0 and astute thinks it done. This is confirmed on puppet 2.7. We need to verify if this applies to puppet 3.4, If so it needs to be accommodated for.

[Vladimir Sharshov (vsharshov)]

We run puppet using daemon and we could not get error code about catalog. We can create special check which would run before real puppet run and prevent running if we got error.

Command for check: puppet apply --noop /etc/puppet/manifests/site.pp

Example:
[root@node-5 ~]# puppet apply --noop /etc/puppet/manifests/site.pp
Error: Duplicate declaration: Stage[zero] is already declared in file /etc/puppet/manifests/site.pp:15; cannot redeclare at /etc/puppet/manifests/site.pp:20 on node node-5.domain.tld
Error: Duplicate declaration: Stage[zero] is already declared in file /etc/puppet/manifests/site.pp:15; cannot redeclare at /etc/puppet/manifests/site.pp:20 on node node-5.domain.tld
[root@node-5 ~]# echo $?
1

It can take perceptible time (3-5 minutes for controller node).

[Vladimir Sharshov (vsharshov)]

Problem more complicated. --noop return bad code if catalog compiled succeed, but process emulation failed because required bin files missed.

[Dmitry Ilyin (idv1985)]

We need to add --only-catalog option for puppet apply

[Vladimir Sharshov (vsharshov)]

Osci guys, please create separate repo and include this patch for puppet 3.4.2 for Ubuntu and Centos client nodes

Projects:
- openstack-ci/precise/puppet
- openstack-ci/centos64/puppet

[OSCI Robot (oscirobot)]

Package puppet has been built from changeset: http://gerrit.mirantis.com/21248
RPM Repository URL: http:///osci-obs.vm.mirantis.net:82/centos-fuel-master-21248/centos

[OSCI Robot (oscirobot)]

Package puppet has been built from changeset: http://gerrit.mirantis.com/21250
DEB Repository URL: http:///osci-obs.vm.mirantis.net:82/ubuntu-fuel-master-21250/ubuntu

[OSCI Robot (oscirobot)]

Package puppet has been built from changeset: http://gerrit.mirantis.com/21248
RPM Repository URL: http:///osci-obs.vm.mirantis.net:82/centos-fuel-master-21248/centos

[Dmitry Ilyin (idv1985)]

POrting this algorith to puppetd mco agent will help too https://review.openstack.org/#/c/130286/5/tasklib/tasklib/actions/puppet.py,cm

[OSCI Robot (oscirobot)]

DEB package puppet has been built for project packages/precise/puppet
Package version == 3.4.2, package release == ubuntu1

Changeset: https://review.fuel-infra.org/1300
project: packages/precise/puppet
branch: 6.0
author: Vladimir Kuklin
committer: Vladimir Kuklin
subject: Apply patch catalog-compilation-exit-code.patch to v.3.4.2
status: patchset-created

Files placed on repository:
puppet-common_3.4.2-ubuntu1_all.deb
puppet-el_3.4.2-ubuntu1_all.deb
puppet-testsuite_3.4.2-ubuntu1_all.deb
puppet_3.4.2-ubuntu1_all.deb
puppetmaster-common_3.4.2-ubuntu1_all.deb
puppetmaster-passenger_3.4.2-ubuntu1_all.deb
puppetmaster_3.4.2-ubuntu1_all.deb
vim-puppet_3.4.2-ubuntu1_all.deb

NOTE: Changeset is not merged, created temporary package repository.
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable-1300/ubuntu

[OSCI Robot (oscirobot)]

RPM package puppet has been built for project packages/centos6/puppet
Package version == 3.4.2, package release == 2

Changeset: https://review.fuel-infra.org/1298
project: packages/centos6/puppet
branch: 6.0
author: Vladimir Kuklin
committer: Vladimir Kuklin
subject: Apply patch catalog-compilation-exit-code.patch to v.3.4.2
status: patchset-created

Files placed on repository:
puppet-3.4.2-2.mira3.noarch.rpm
puppet-server-3.4.2-2.mira3.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable-1298/centos

[OSCI Robot (oscirobot)]

RPM package puppet has been built for project packages/centos6/puppet
Package version == 3.4.2, package release == 2

Changeset: https://review.fuel-infra.org/1298
project: packages/centos6/puppet
branch: 6.0
author: Vladimir Kuklin
committer: Vladimir Kuklin
subject: Apply patch catalog-compilation-exit-code.patch to v.3.4.2
status: change-merged

Files placed on repository:
puppet-3.4.2-2.mira3.noarch.rpm
puppet-server-3.4.2-2.mira3.noarch.rpm

Changeset merged. Package placed on primary repository
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable/centos

[OSCI Robot (oscirobot)]

DEB package puppet has been built for project packages/precise/puppet
Package version == 3.4.2, package release == ubuntu1

Changeset: https://review.fuel-infra.org/1300
project: packages/precise/puppet
branch: 6.0
author: Vladimir Kuklin
committer: Vladimir Kuklin
subject: Apply patch catalog-compilation-exit-code.patch to v.3.4.2
status: change-merged

Files placed on repository:
puppet-common_3.4.2-ubuntu1_all.deb
puppet-el_3.4.2-ubuntu1_all.deb
puppet-testsuite_3.4.2-ubuntu1_all.deb
puppet_3.4.2-ubuntu1_all.deb
puppetmaster-common_3.4.2-ubuntu1_all.deb
puppetmaster-passenger_3.4.2-ubuntu1_all.deb
puppetmaster_3.4.2-ubuntu1_all.deb
vim-puppet_3.4.2-ubuntu1_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable/ubuntu

[Anastasia Palkina (apalkina)]

There is old package on ISO #49

-rwxr-xr-x. 1 root root 9610 Дек 16 10:17 puppet_3.4.2-1puppetlabs1_all.deb

Need to verify on new RC

[Anastasia Palkina (apalkina)]

Verified on ISO #56

"build_id": "2014-12-18_01-32-01", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "56", "auth_required": true, "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "45caacadb878abfbd9d60e134d72229698b469c9", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-18_01-32-01", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "56", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "45caacadb878abfbd9d60e134d72229698b469c9", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "73332192a257ea02c40a39885c502ad1ebdf3eda"}}}, "fuellib_sha": "73332192a257ea02c40a39885c502ad1ebdf3eda"