Requirements change and check causes proposal failure

Bug #1326504 reported by Brant Knudson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
Undecided
Brant Knudson

Bug Description

This change ( https://review.openstack.org/#/c/96265/ ) in openstack/python-keystoneclient is an update to the global requirements coming from the proposal bot. It's failing with an incompatible requirement found[1]:

2014-06-04 16:49:14.701 | requirements git sha: 3611a35c6a3ea4e97e7e162f7e80ca2288054a08
2014-06-04 16:49:14.701 | Requirement sphinx>=1.2.1,<1.3 does not overlap with branch
2014-06-04 16:49:14.701 | Requirement sphinx>=1.2.1,<1.3 does not overlap with branch

The only change in the review is changing sphinx>=1.1.2,<1.2 to sphinx>=1.2.1,<1.3

Which was merged recently to requirements: https://review.openstack.org/#/c/88631/

The change to check for overlapping requirements was also merged recently:
https://review.openstack.org/#/c/84100/

[1] http://logs.openstack.org/65/96265/4/check/gate-python-keystoneclient-requirements/364c99f/console.html

Changed in openstack-ci:
assignee: nobody → Brant Knudson (blk-u)
status: New → In Progress
Revision history for this message
Jeremy Stanley (fungi) wrote :

The change introducing this behavior was intended to solve bug 1274731, but in fact should have been checking proposed changes to the openstack/requirements project's global-requirements.txt rather than individual projects' requirements files.

Revision history for this message
Brant Knudson (blk-u) wrote :

Proposed a revert of https://review.openstack.org/#/c/84100/ here: https://review.openstack.org/#/c/97893/
(as a partial fix, I don't know what the real fix is, but just wanted to get started).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98426

Changed in designate:
importance: Undecided → High
status: New → Triaged
importance: High → Undecided
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.openstack.org/97893
Committed: https://git.openstack.org/cgit/openstack-infra/config/commit/?id=c456411c9a172d0f5888bce70787a112de8cb446
Submitter: Jenkins
Branch: master

commit c456411c9a172d0f5888bce70787a112de8cb446
Author: Brant Knudson <email address hidden>
Date: Wed Jun 4 19:39:35 2014 +0000

    Revert "Checks if requirements overlap between head and branch reqs"

    This reverts commit a57bd21836a7441a626c46098b25c4a9c3920b1a.

    Partial-Bug: #1326504

    Change-Id: I2131cb09464cc7976df422974baa3358db9360b1

Revision history for this message
Brant Knudson (blk-u) wrote :

Here's the proposed changes to fix it. Not sure if they're right or not, but a broken clock is right twice a day.

1) "Add a tox env to check requirements overlap" in openstack/requirements : https://review.openstack.org/#/c/98262/
2) "For requirements, run job to verify that requirements overlap" in openstack-infra/config : https://review.openstack.org/#/c/98426/

Kiall Mac Innes (kiall)
no longer affects: designate
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/98426
Committed: https://git.openstack.org/cgit/openstack-infra/config/commit/?id=ec6bc392a46846409e23d367d1a352a2bd622c26
Submitter: Jenkins
Branch: master

commit ec6bc392a46846409e23d367d1a352a2bd622c26
Author: Brant Knudson <email address hidden>
Date: Fri Jun 6 09:24:53 2014 -0500

    For requirements, run job to verify that requirements overlap

    There was no job that checks that the latest requirements change
    overlaps with the ancenstor commit's requirements.

    This requires that there's a tox environment versions-overlap-parent
    in openstack/requirements. This is added with
    https://review.openstack.org/#/c/98262/ .

    Change-Id: Ia852869b75c4a262879a1a94a285094545bde0fb
    Closes-Bug: #1326504

Changed in openstack-ci:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.