increase the width of subcommand column in the help output

Bug #1326471 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python client library for Sahara
Invalid
Undecided
Christian Berendt
python-ceilometerclient
Fix Released
Undecided
Christian Berendt
python-cinderclient
Won't Fix
Undecided
Christian Berendt
python-keystoneclient
Fix Released
Low
Christian Berendt
python-novaclient
Fix Released
Undecided
Christian Berendt
python-troveclient
Fix Released
Low
Christian Berendt

Bug Description

Some subcommands does not fit the current width of the subcommand column resulting in needless line breaks like in http://paste.openstack.org/show/82813/.

Changed in python-novaclient:
assignee: nobody → Christian Berendt (berendt)
Changed in python-ceilometerclient:
assignee: nobody → Christian Berendt (berendt)
Changed in python-keystoneclient:
assignee: nobody → Christian Berendt (berendt)
Changed in python-cinderclient:
assignee: nobody → Christian Berendt (berendt)
Changed in python-troveclient:
assignee: nobody → Christian Berendt (berendt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97873

Changed in python-keystoneclient:
status: New → In Progress
Changed in python-saharaclient:
assignee: nobody → Christian Berendt (berendt)
Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97881

Changed in python-ceilometerclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97882

Changed in python-cinderclient:
status: New → In Progress
Changed in python-saharaclient:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-troveclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97886

Changed in python-troveclient:
status: New → In Progress
Changed in python-troveclient:
importance: Undecided → Low
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/97870
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=8bef1e11107076660c3ea204d1419eb755b56b70
Submitter: Jenkins
Branch: master

commit 8bef1e11107076660c3ea204d1419eb755b56b70
Author: Christian Berendt <email address hidden>
Date: Wed Jun 4 20:11:17 2014 +0200

    Overwrite HelpFormatter constructur to extend argument column

    Overwrite the HelpFormatter constructor in the class
    OpenStackHelpFormatter to modify the default value of the
    max_help_position to extend the width of the argument column
    in the help output.

    example output before this patch:

        volume-snapshot-create
                            Add a new snapshot.
        volume-snapshot-delete
                            Remove a snapshot.
        volume-snapshot-list
                            List all the snapshots.
        volume-snapshot-show
                            Show details about a snapshot.

    example output after this patch:

        volume-snapshot-create Add a new snapshot.
        volume-snapshot-delete Remove a snapshot.
        volume-snapshot-list List all the snapshots.
        volume-snapshot-show Show details about a snapshot.

    Change-Id: I517098748947e7bded03160a15e778bf79475d0d
    Closes-Bug: #1326471

Changed in python-novaclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-troveclient (master)

Reviewed: https://review.openstack.org/97886
Committed: https://git.openstack.org/cgit/openstack/python-troveclient/commit/?id=12d484160c3b3367bd2cfc6eeb5f6ec7669252a6
Submitter: Jenkins
Branch: master

commit 12d484160c3b3367bd2cfc6eeb5f6ec7669252a6
Author: Christian Berendt <email address hidden>
Date: Wed Jun 4 21:15:17 2014 +0200

    Overwrite HelpFormatter constructur to extend argument column

    Overwrite the HelpFormatter constructor in the class
    OpenStackHelpFormatter to modify the default value of the
    max_help_position to extend the width of the argument column
    in the help output.

    example output before this patch:

        configuration-attach
                            Attaches a configuration group to an instance.
        configuration-create
                            Creates a configuration group.
        configuration-default
                            Shows the default configuration of an instance.
        configuration-delete
                            Deletes a configuration group.
        configuration-detach
                            Detaches a configuration group from an instance.

    example output after this patch:

        configuration-attach Attaches a configuration group to an
                                      instance.
        configuration-create Creates a configuration group.
        configuration-default Shows the default configuration of an
                                      instance.
        configuration-delete Deletes a configuration group.
        configuration-detach Detaches a configuration group from an
                                      instance.

    Change-Id: Ia3ad8e9fefca6da40f55ab3de902c015a0d17006
    Closes-Bug: #1326471

Changed in python-troveclient:
status: In Progress → Fix Committed
Michael Still (mikal)
Changed in python-novaclient:
milestone: none → 2.18.0
Michael Still (mikal)
Changed in python-novaclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ceilometerclient (master)

Reviewed: https://review.openstack.org/97881
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=d864c23aa84a437d726cd761646b684c520f0281
Submitter: Jenkins
Branch: master

commit d864c23aa84a437d726cd761646b684c520f0281
Author: Christian Berendt <email address hidden>
Date: Wed Jun 4 21:03:42 2014 +0200

    Calculate a suitable column width for positional arguments

    Overwrite the method add_arguments in the class
    OpenStackHelpFormatter to calculate a suitable columnt width
    (max_help_position) for the positional arguments.

    example output before this patch:

        alarm-threshold-create
                            Create a new alarm based on computed statistics.
        alarm-threshold-update
                            Update an existing alarm based on computed statistics.
        alarm-update Update an existing alarm (Deprecated).

    example output after this patch:

        alarm-threshold-create Create a new alarm based on computed statistics.
        alarm-threshold-update Update an existing alarm based on computed
                                  statistics.
        alarm-update Update an existing alarm (Deprecated).

    Change-Id: I945e46bb9e0309b960e3322261d9d6ff9fa35b52
    Closes-Bug: #1326471

Changed in python-ceilometerclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/97873
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=a31cc3293eaeecf7494c226b2211fd0f219d4bea
Submitter: Jenkins
Branch: master

commit a31cc3293eaeecf7494c226b2211fd0f219d4bea
Author: Christian Berendt <email address hidden>
Date: Wed Jun 4 20:27:06 2014 +0200

    Calculate a suitable column width for positional arguments

    Overwrite the method add_arguments in the class
    OpenStackHelpFormatter to calculate a suitable columnt width
    (max_help_position) for the positional arguments.

    example output before this patch:

        ec2-credentials-create
                            Create EC2-compatible credentials for user per tenant.
        ec2-credentials-delete
                            Delete EC2-compatible credentials.
        ec2-credentials-get
                            Display EC2-compatible credentials.
        ec2-credentials-list
                            List EC2-compatible credentials for a user.

    example output after this patch:

        ec2-credentials-create Create EC2-compatible credentials for user per
                                tenant.
        ec2-credentials-delete Delete EC2-compatible credentials.
        ec2-credentials-get Display EC2-compatible credentials.
        ec2-credentials-list List EC2-compatible credentials for a user.

    Change-Id: Ibd5d3502022d2afcfd4f57fef9a0bbf23d34b767
    Closes-Bug: #1326471

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.11.0
importance: Undecided → Low
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Christian Berendt (<email address hidden>) on branch: master
Review: https://review.openstack.org/97882
Reason: out of date

Changed in python-ceilometerclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
Changed in python-cinderclient:
status: In Progress → Won't Fix
Zhao Chao (zhaochao1984)
Changed in python-troveclient:
milestone: juno-1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.