Launching instance fails when Nova doesn't support DiskConfig

[Wu Hong Guang]

Setup: Nova does not support DiskConfig extension

Test step:

1: login as admin
2:go to Project->Computer->Instances
3:launch instance

I've attached the horizon_error.log

[Lin Hua Cheng (lin-hua-cheng)]

I can reproduce the issue when Nova does not support DiskConfig.

disk_config field is removed from the workflow if the Nova does not support it. (added in https://review.openstack.org/#/c/90284/)

However it is still accessed in the handle() method

      try:
            api.nova.server_create(request,
                                   ...
                                   disk_config=context['disk_config'])
            return True

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/98019

[Loganathan Parthipan (parthipan)]

Does nova handle the case if there's no disk_config specified?

[Eric Peterson (ericpeterson-l)]

still occuring, error is:

[Thu Jun 05 14:55:09 2014] [error] Internal Server Error: /project/instances/launch
[Thu Jun 05 14:55:09 2014] [error] Traceback (most recent call last):
[Thu Jun 05 14:55:09 2014] [error] File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 112, in get_response
[Thu Jun 05 14:55:09 2014] [error] response = wrapped_callback(request, *callback_args, **callback_kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/decorators.py", line 36, in dec
[Thu Jun 05 14:55:09 2014] [error] return view_func(request, *args, **kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/decorators.py", line 52, in dec
[Thu Jun 05 14:55:09 2014] [error] return view_func(request, *args, **kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/decorators.py", line 36, in dec
[Thu Jun 05 14:55:09 2014] [error] return view_func(request, *args, **kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/usr/local/lib/python2.7/dist-packages/django/views/generic/base.py", line 69, in view
[Thu Jun 05 14:55:09 2014] [error] return self.dispatch(request, *args, **kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/usr/local/lib/python2.7/dist-packages/django/views/generic/base.py", line 87, in dispatch
[Thu Jun 05 14:55:09 2014] [error] return handler(request, *args, **kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/workflows/views.py", line 193, in post
[Thu Jun 05 14:55:09 2014] [error] exceptions.handle(request)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/workflows/views.py", line 188, in post
[Thu Jun 05 14:55:09 2014] [error] success = workflow.finalize()
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/workflows/base.py", line 802, in finalize
[Thu Jun 05 14:55:09 2014] [error] if not self.handle(self.request, self.context):
[Thu Jun 05 14:55:09 2014] [error] File "/usr/local/lib/python2.7/dist-packages/django/views/decorators/debug.py", line 36, in sensitive_variables_wrapper
[Thu Jun 05 14:55:09 2014] [error] return func(*func_args, **func_kwargs)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/project/instances/workflows/create_instance.py", line 758, in handle
[Thu Jun 05 14:55:09 2014] [error] exceptions.handle(request)
[Thu Jun 05 14:55:09 2014] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/project/instances/workflows/create_instance.py", line 755, in handle
[Thu Jun 05 14:55:09 2014] [error] disk_config=context['disk_config'])
[Thu Jun 05 14:55:09 2014] [error] KeyError: 'disk_config'

[Eric Peterson (ericpeterson-l)]

problem is that a dict get call should have been used.....

            api.nova.server_create(request,
                                   context['name'],
                                   image_id,
                                   context['flavor'],
                                   context['keypair_id'],
                                   normalize_newlines(custom_script),
                                   context['security_group_ids'],
                                   block_device_mapping=dev_mapping_1,
                                   block_device_mapping_v2=dev_mapping_2,
                                   nics=nics,
                                   availability_zone=avail_zone,
                                   instance_count=int(context['count']),
                                   admin_pass=context['admin_pass'],
                                   disk_config=context['disk_config'])

[Lin Hua Cheng (lin-hua-cheng)]

Loganathan: Yes, the None value of disk_config is just ignored.

[Lin Hua Cheng (lin-hua-cheng)]

Patch does not need to be backported, the bug was introduced by a patch that was merged in J-1: https://review.openstack.org/#/c/90284/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98019
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cb7b559f0fb52ddd8f6cf3475e0d59ef3f12a89c
Submitter: Jenkins
Branch: master

commit cb7b559f0fb52ddd8f6cf3475e0d59ef3f12a89c
Author: lin-hua-cheng <email address hidden>
Date: Wed Jun 4 21:00:23 2014 -0700

    Fix issue when Nova does not support DiskConfig

    When DiskConfig is not support by Nova, the disk_config field is
    removed from the form. This fix takes care of safely handling the
    case when the field is not available.

    Change-Id: I44727eb3fc44c209b3b8cf28ab89a45c7d3bcfa1
    Closes-Bug: #1326406

[Wu Hong Guang (whg)]

This bug is fixed