Broken HostManager: TypeError: __init__() takes at most 4 arguments (5 given)

Bug #1326312 reported by Lucas Alvares Gomes
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Critical
Robert Collins

Bug Description

======================================================================
FAIL: ironic.nova.tests.scheduler.test_ironic_host_manager.IronicHostManagerChangedNodesTestCase.test_get_all_host_states
tags: worker-7
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "ironic/nova/tests/scheduler/test_ironic_host_manager.py", line 120, in test_get_all_host_states
    self.host_manager.get_all_host_states(context)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/nova/scheduler/host_manager.py", line 453, in get_all_host_states
    host_state = self.host_state_cls(host, node, compute)
  File "ironic/nova/scheduler/ironic_host_manager.py", line 94, in new_host_state
    return host_manager.HostState(host, node, capabilities, service)
TypeError: __init__() takes at most 4 arguments (5 given)
======================================================================
FAIL: ironic.nova.tests.scheduler.test_ironic_host_manager.IronicHostManagerTestCase.test_get_all_host_states
tags: worker-3
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "ironic/nova/tests/scheduler/test_ironic_host_manager.py", line 59, in test_get_all_host_states
    self.host_manager.get_all_host_states(context)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/nova/scheduler/host_manager.py", line 453, in get_all_host_states
    host_state = self.host_state_cls(host, node, compute)
  File "ironic/nova/scheduler/ironic_host_manager.py", line 94, in new_host_state
    return host_manager.HostState(host, node, capabilities, service)
TypeError: __init__() takes at most 4 arguments (5 given)
======================================================================
FAIL: ironic.nova.tests.scheduler.test_ironic_host_manager.IronicHostManagerChangedNodesTestCase.test_get_all_host_states_after_delete_all
tags: worker-1
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  stderr
  stdout

traceback-1: {{{
Traceback (most recent call last):
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/fixtures/fixture.py", line 112, in cleanUp
    return self._cleanups(raise_errors=raise_first)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/fixtures/callmany.py", line 88, in __call__
    reraise(error[0], error[1], error[2])
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/fixtures/callmany.py", line 82, in __call__
    cleanup(*args, **kwargs)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/mox.py", line 286, in VerifyAll
    mock_obj._Verify()
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/mox.py", line 506, in _Verify
    raise ExpectedMethodCallsError(self._expected_calls_queue)
ExpectedMethodCallsError: Verify: Expected methods never called:
  0. compute_node_get_all.__call__('fake_context') -> []
}}}

Traceback (most recent call last):
  File "ironic/nova/tests/scheduler/test_ironic_host_manager.py", line 153, in test_get_all_host_states_after_delete_all
    self.host_manager.get_all_host_states(context)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/nova/scheduler/host_manager.py", line 453, in get_all_host_states
    host_state = self.host_state_cls(host, node, compute)
  File "ironic/nova/scheduler/ironic_host_manager.py", line 94, in new_host_state
    return host_manager.HostState(host, node, capabilities, service)
TypeError: __init__() takes at most 4 arguments (5 given)
======================================================================
FAIL: process-returncode
tags: worker-7
----------------------------------------------------------------------
Binary content:
  traceback (test/plain; charset="utf8")
======================================================================
FAIL: ironic.nova.tests.scheduler.test_ironic_host_manager.IronicHostManagerChangedNodesTestCase.test_get_all_host_states_after_delete_one
tags: worker-6
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  stderr
  stdout

traceback-1: {{{
Traceback (most recent call last):
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/fixtures/fixture.py", line 112, in cleanUp
    return self._cleanups(raise_errors=raise_first)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/fixtures/callmany.py", line 88, in __call__
    reraise(error[0], error[1], error[2])
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/fixtures/callmany.py", line 82, in __call__
    cleanup(*args, **kwargs)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/mox.py", line 286, in VerifyAll
    mock_obj._Verify()
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/mox.py", line 506, in _Verify
    raise ExpectedMethodCallsError(self._expected_calls_queue)
ExpectedMethodCallsError: Verify: Expected methods never called:
  0. compute_node_get_all.__call__('fake_context') -> [{'supported_instances': '[["i386", "baremetal", "baremetal"]]', 'host_ip': '127.0.0.1', 'hypervisor_hostname': 'node1uuid', 'updated_at': None, 'cpu_info': 'baremetal cpu', 'free_disk_gb': 10, 'hypervisor_version': 1, 'local_gb': 10, 'free_ram_mb': 1024, 'id': 1, 'stats': {'cpu_arch': 'i386', 'ironic_driver': 'nova.virt.ironic.driver.IronicDriver'}, 'service': {'disabled': False, 'host': 'host1'}, 'vcpus_used': 0, 'hypervisor_type': 'ironic', 'local_gb_used': 0, 'memory_mb_used': 0, 'memory_mb': 1024, 'vcpus': 1}, {'supported_instances': '[["i386", "baremetal", "baremetal"]]', 'host_ip': '127.0.0.1', 'hypervisor_hostname': 'node2uuid', 'updated_at': None, 'cpu_info': 'baremetal cpu', 'free_disk_gb': 20, 'hypervisor_version': 1, 'local_gb': 20, 'free_ram_mb': 2048, 'id': 2, 'stats': {'cpu_arch': 'i386', 'ironic_driver': 'nova.virt.ironic.driver.IronicDriver'}, 'service': {'disabled': True, 'host': 'host2'}, 'vcpus_used': 0, 'hypervisor_type': 'ironic', 'local_gb_used': 0, 'memory_mb_used': 0, 'memory_mb': 2048, 'vcpus': 1}, {'supported_instances': '[["i386", "baremetal", "baremetal"]]', 'host_ip': '127.0.0.1', 'hypervisor_hostname': 'node3uuid', 'updated_at': None, 'cpu_info': 'baremetal cpu', 'free_disk_gb': 30, 'hypervisor_version': 1, 'local_gb': 30, 'free_ram_mb': 3072, 'id': 3, 'stats': {'cpu_arch': 'i386', 'ironic_driver': 'nova.virt.ironic.driver.IronicDriver'}, 'service': {'disabled': False, 'host': 'host3'}, 'vcpus_used': 0, 'hypervisor_type': 'ironic', 'local_gb_used': 0, 'memory_mb_used': 0, 'memory_mb': 3072, 'vcpus': 1}, {'stats': {'cpu_arch': 'i386', 'ironic_driver': 'nova.virt.ironic.driver.IronicDriver'}, 'service': None, 'supported_instances': '[["i386", "baremetal", "baremetal"]]', 'memory_mb': 5120, 'cpu_info': 'baremetal cpu', 'vcpus': 1, 'free_disk_gb': 50, 'local_gb': 50, 'free_ram_mb': 5120, 'id': 5}]
}}}

Traceback (most recent call last):
  File "ironic/nova/tests/scheduler/test_ironic_host_manager.py", line 137, in test_get_all_host_states_after_delete_one
    self.host_manager.get_all_host_states(context)
  File "/home/lucasagomes/Projects/ironic/.tox/py27/lib/python2.7/site-packages/nova/scheduler/host_manager.py", line 453, in get_all_host_states
    host_state = self.host_state_cls(host, node, compute)
  File "ironic/nova/scheduler/ironic_host_manager.py", line 94, in new_host_state
    return host_manager.HostState(host, node, capabilities, service)
TypeError: __init__() takes at most 4 arguments (5 given)
======================================================================
FAIL: process-returncode
tags: worker-3
----------------------------------------------------------------------
Binary content:
  traceback (test/plain; charset="utf8")
======================================================================
FAIL: process-returncode
tags: worker-1
----------------------------------------------------------------------
Binary content:
  traceback (test/plain; charset="utf8")
======================================================================
FAIL: process-returncode
tags: worker-6
----------------------------------------------------------------------
Binary content:
  traceback (test/plain; charset="utf8")
Ran 79 (-770) tests in 0.841s (-2.713s)
FAILED (id=1, failures=8 (+8))
error: testr failed (1)
ERROR: InvocationError: "/usr/bin/bash -c TESTS_DIR=./ironic/nova/tests/ python setup.py testr --slowest --testr-args='--parallel'"
py27 runtests: commands[2] | bash -c cat .testrepository/1 >>.testrepository/0

Changed in ironic:
importance: Undecided → High
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
Hans Lindgren (hanlind) wrote :

This is due to a recent change in Nova. See https://review.openstack.org/94043
A fix for Ironic is provided in https://review.openstack.org/97447

Changed in ironic:
assignee: Lucas Alvares Gomes (lucasagomes) → Hans Lindgren (hanlind)
status: New → In Progress
Revision history for this message
Lucas Alvares Gomes (lucasagomes) wrote :

Ah nice, thanks Hans!

Revision history for this message
Dmitry Tantsur (divius) wrote :

Thanks for taking this, let us provide fix asap, all gates are broken now

Changed in ironic:
importance: High → Critical
Changed in ironic:
assignee: Hans Lindgren (hanlind) → Robert Collins (lifeless)
aeva black (tenbrae)
summary: - Broken HostManager: ypeError: __init__() takes at most 4 arguments (5
+ Broken HostManager: TypeError: __init__() takes at most 4 arguments (5
given)
Dan Prince (dan-prince)
no longer affects: tripleo
Revision history for this message
aeva black (tenbrae) wrote :

Fixed in Nova by reverting the original change. See
  https://review.openstack.org/#/c/97757/

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.