allowed address pairs - overlap check

[Liping Mao]

This bug is relate with the following bug:
https://bugs.launchpad.net/neutron/+bug/1321864

The fix patch for the bug delete overlap check for fixed ip and allowed ip address range.

I think that we also need to remove the following code if we do not need to check fixed_ip and allowed address pair overlap:
https://github.com/openstack/neutron/blob/master/neutron/db/allowedaddresspairs_db.py
51 for fixed_ip in port['fixed_ips']:
52 if ((fixed_ip['ip_address'] == address_pair['ip_address'])
53 and (port['mac_address'] ==
54 address_pair['mac_address'])):
55 raise addr_pair.AddressPairMatchesPortFixedIPAndMac()

https://github.com/openstack/neutron/blob/master/neutron/extensions/allowedaddresspairs.py
35class AddressPairMatchesPortFixedIPAndMac(nexception.InvalidInput):
36 message = _("Port's Fixed IP and Mac Address match an address pair entry.")

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/97706

[yong sheng gong (gongysh)]

I am not clear why you need to delete the code, which is used to prevent the same ip/mac as port fixed ips are added as allowed_address_pair.

[Liping Mao (limao)]

Hi Gong,

In the following bug, it delete the allowed_address_pair range and fixed ips overlap:
https://bugs.launchpad.net/neutron/+bug/1321864

I think it is very strange if we only check allowed_address_pair and fixed ip overlap.
I think we should either check overlap in all situation or do not check overlap in all situation.

BTW, if we do not check the overlap, I think that it will not cause any bad thing..

Thanks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97706
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=03277a80d573161abd0d1cb81ec647b53e140063
Submitter: Jenkins
Branch: master

commit 03277a80d573161abd0d1cb81ec647b53e140063
Author: Liping Mao <email address hidden>
Date: Wed Jun 4 15:41:44 2014 +0800

    Allowed address pair: Removing check for overlap with fixed ips

    Some of the overlap check has been removed in the following patch:
    https://review.openstack.org/#/c/94508/
    But the patch did not remove all the overlap check. I remove the
    rest part.

    Change-Id: I575ec54c0b3d6dc31ef80819d4258c6d162b4cfd
    Closes-Bug: #1326007