Huge test case for Ironic Nova driver should be split
Bug #1325906 reported by
Dmitry Tantsur
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Won't Fix
|
Wishlist
|
Unassigned | ||
OpenStack Compute (nova) |
Won't Fix
|
Wishlist
|
Aniruddha Singh Gautam |
Bug Description
Currently, tests for Ironic Nova driver consist of one giant test case. That is not convenient from mocking point of view, as it requires different set of mocks to be places on every method. It is also hard to reason about. Splitting into several meaningful test cases will allow to have mock decorators mostly at class-levels, which will lead to less cluttered code. It will also simplify review for Nova folks.
Changed in ironic: | |
status: | New → Triaged |
importance: | Undecided → Wishlist |
tags: | added: low-hanging-fruit |
Changed in ironic: | |
assignee: | nobody → Zhongyue Luo (zyluo) |
Changed in nova: | |
importance: | Undecided → Wishlist |
status: | New → Triaged |
Changed in ironic: | |
assignee: | Zhongyue Luo (zyluo) → nobody |
Changed in nova: | |
assignee: | nobody → Ankur Gupta (ankur-gupta-v) |
status: | Triaged → In Progress |
Changed in nova: | |
assignee: | Ankur Gupta (ankur-gupta-v) → Jeremy Stanley (fungi) |
Changed in nova: | |
assignee: | Ankur Gupta (ankur-gupta-v) → nobody |
status: | In Progress → Confirmed |
Changed in nova: | |
assignee: | nobody → Aniruddha Singh Gautam (aniruddha-gautam) |
Changed in nova: | |
status: | Confirmed → Won't Fix |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/106933
Review: https:/